Skip to content

Ensure cuda is a namespace package & Improve warnings - #493

Merged
leofang merged 7 commits into
NVIDIA:mainfrom
leofang:cleanup_main_py
Apr 21, 2025
Merged

Ensure cuda is a namespace package & Improve warnings#493
leofang merged 7 commits into
NVIDIA:mainfrom
leofang:cleanup_main_py

Conversation

@leofang

@leofangleofang commented Mar 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Close#477. Close#162.

@leofangleofang self-assigned this Mar 6, 2025
@copy-pr-bot

copy-pr-botBot commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Mar 6, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@leofangleofang added bug Something isn't working enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Mar 6, 2025
rwgk
rwgk previously approved these changes Mar 6, 2025
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks great to me!

I'm wondering though, what exactly was the reason for adding these files? How much trouble is it to leave some hints in the PR description?

@leofangleofang mentioned this pull request Mar 23, 2025
Merged
@leofangleofang changed the title Ensure cuda is a namespace packageEnsure cuda is a namespace package & Improve warningsApr 4, 2025
@leofang

leofang commented Apr 4, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@leofang

leofang commented Apr 4, 2025

Copy link
Copy Markdown
MemberAuthor

what exactly was the reason for adding these files? How much trouble is it to leave some hints in the PR description?

As part of the epic #493, we need to remove cuda/__init__.py to ensure cuda is a namespace package. The existence of this file has been a source of multiple traps and bugs.

We still kept it around because it used to provide cuda.__version__. Since we have raised a deprecation warning for a few releases, and it is a minor thing, we now remove it entirely.

@leofang
leofang marked this pull request as ready for review April 7, 2025 22:18
@leofang

leofang commented Apr 7, 2025

Copy link
Copy Markdown
MemberAuthor

This is ready for review. I was hoping to address #517 (comment), but it seems the original issue (leading to our weird MANIFEST.in) still persists.

@leofang
leofang requested a review from vzhurba01April 7, 2025 22:23
vzhurba01
vzhurba01 previously approved these changes Apr 8, 2025
View reviewed changes
leofang
leofang commented Apr 8, 2025
View reviewed changes
Comment threadcuda_bindings/cuda/__init__.py
@leofang

leofang commented Apr 18, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@copy-pr-bot

copy-pr-botBot commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@leofang, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@leofang

leofang commented Apr 18, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 88144ee

@leofang
leofang merged commit db7c854 into NVIDIA:mainApr 21, 2025
@leofang
leofang deleted the cleanup_main_py branch April 21, 2025 15:42
@github-actions

github-actionsBot commented Apr 21, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 approved these changes
@rwgkrwgkrwgk left review comments
+1 more reviewer
@vzhurba01vzhurba01vzhurba01 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@leofangleofang

Labels

bugSomething isn't workingcuda.bindingsEverything related to the cuda.bindings moduleenhancementAny code-related improvementsP0High priority - Must do!

Projects

None yet

Milestone

cuda-python 12.9.0 & 11.8.7

Development

Successfully merging this pull request may close these issues.

Remove cuda/__init__.py to avoid confusing various tools Turn DeprecationWarning to UserWarning

4 participants

@leofang@rwgk@kkraus14@vzhurba01