Skip to content

cuda.core: CUResult, cudaError explanations - #503

Merged
rwgk merged 8 commits into
NVIDIA:mainfrom
rwgk:error_explanations
Mar 26, 2025
Merged

cuda.core: CUResult, cudaError explanations#503
rwgk merged 8 commits into
NVIDIA:mainfrom
rwgk:error_explanations

Conversation

@rwgk

@rwgkrwgk commented Mar 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#198

Produce more informative error messages than what the driver or runtime libraries have built in.

@copy-pr-bot

copy-pr-botBot commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Mar 8, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@rwgkrwgk changed the title [WIP] cuda.core: CUResult, cudaError explanationscuda.core: CUResult, cudaError explanationsMar 8, 2025
@rwgk
rwgk marked this pull request as ready for review March 8, 2025 19:42
@copy-pr-bot

copy-pr-botBot commented Mar 8, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk
rwgk requested a review from leofangMarch 8, 2025 19:42
@leofangleofang added this to the cuda.core beta 4 milestone Mar 9, 2025
@leofangleofang added P0 High priority - Must do! feature New feature or request cuda.core Everything related to the cuda.core module labels Mar 9, 2025
kkraus14
kkraus14 reviewed Mar 10, 2025
View reviewed changes
Comment threadcuda_core/cuda/core/experimental/_utils/driver_cu_result_explanations.py Outdated
@rwgk

rwgk commented Mar 10, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

keenan-simpson
keenan-simpson reviewed Mar 11, 2025
View reviewed changes

@keenan-simpsonkeenan-simpson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally really like it. Hopefully we can revert it all one day if error messages improve from upstream in the callstack. Will approve after code freeze :)

@rwgk

rwgk commented Mar 17, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@rwgk

rwgk commented Mar 26, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@rwgk

rwgk commented Mar 26, 2025

Copy link
Copy Markdown
ContributorAuthor

I freshly updated this PR (git merge main).

@ksimpson-work or @leofang, could someone please approve?

@rwgk
rwgk merged commit 73fa3c0 into NVIDIA:mainMar 26, 2025
@rwgk
rwgk deleted the error_explanations branch March 26, 2025 17:31
@github-actions

github-actionsBot commented Mar 26, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang

leofang commented Mar 26, 2025

Copy link
Copy Markdown
Member

Awesome!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 left review comments
@leofangleofangAwaiting requested review from leofang
+1 more reviewer
@keenan-simpsonkeenan-simpsonkeenan-simpson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rwgkrwgk

Labels

cuda.coreEverything related to the cuda.core modulefeatureNew feature or requestP0High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 4

Development

Successfully merging this pull request may close these issues.

Make error messages more clear and actionable

4 participants

@rwgk@leofang@kkraus14@keenan-simpson