Skip to content

Import cudart symbols properly - #545

Closed
leofang wants to merge 2 commits into
NVIDIA:mainfrom
leofang:fix_pxi
Closed

Import cudart symbols properly#545
leofang wants to merge 2 commits into
NVIDIA:mainfrom
leofang:fix_pxi

Conversation

@leofang

@leofangleofang commented Apr 2, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Currently I hand-modify this, but we should be able to autogen it.

@leofang
leofang requested a review from vzhurba01April 2, 2025 18:20
@leofangleofang self-assigned this Apr 2, 2025
@copy-pr-bot

copy-pr-botBot commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Apr 2, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test

@github-actions

github-actionsBot commented Apr 2, 2025

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-545/

https://nvidia.github.io/cuda-python/pr-preview/pr-545/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-545/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@vzhurba01

vzhurba01 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

I can apply the fix in autogen and push a commit to this PR.

@vzhurba01

vzhurba01 commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

I'll need #544 to be merged first for this to be a clean commit though.

@vzhurba01vzhurba01 self-assigned this Apr 4, 2025
@leofangleofang removed their assignment Apr 5, 2025
@leofangleofang added this to the cuda-python 12.9.0 & 11.8.7 milestone Apr 5, 2025
@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module P2 Low priority - Nice to have and removed P1 Medium priority - Should do labels Apr 5, 2025
@leofang

leofang commented May 4, 2025

Copy link
Copy Markdown
MemberAuthor

This is done as part of #597. Thanks, @vzhurba01!

@leofangleofang closed this May 4, 2025
@leofang
leofang deleted the fix_pxi branch May 4, 2025 01:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzhurba01vzhurba01Awaiting requested review from vzhurba01

Assignees

@vzhurba01vzhurba01

Labels

cuda.bindingsEverything related to the cuda.bindings moduleenhancementAny code-related improvementsP2Low priority - Nice to have

Projects

None yet

Milestone

cuda-python 13.0.0 & 12.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@vzhurba01