Uh oh!
There was an error while loading. Please reload this page.
CI: Remove fetch_ctk component hardcoding and add hash to filename - #575
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
carterbox
commented
Apr 23, 2025
/ok to test 56ffaef |
This comment has been minimized.
This comment has been minimized.
carterbox
commented
Apr 23, 2025
@leofang, please review |
carterbox
commented
Apr 23, 2025
@cryos, please review? |
cryos
left a comment
There was a problem hiding this comment.
This looks like a solid approach to me, I would say that the CI is self-testing - if this was not working then the builds and/or tests would very likely fail! Great use of defaults. Do we want to add the sanitizer to the default (not sure how much bigger it is) or should it be added to the test run that will use it?
Uh oh!
There was an error while loading. Please reload this page.
carterbox
commented
Apr 24, 2025
I don't have permission to merge anything in this repo. |
rwgk
commented
Apr 24, 2025
Done :-) |
|
Description
Makes API changes to the local fetch_ctk GitHub action, so that non-admin developers can choose which CTK components are installed into the environment.
The hash of the string of the provided CTK components is now appended to the filename so that changing the components will be a cache miss.
closes#571
Checklist
- [ ] New or existing tests cover these changes.- [ ] The documentation is up to date with these changes.There are no tests for the CI, and although I have added a description to the new parameter, there are no docs for the CI?