Skip to content

Add lint instructions - #581

Merged
kkraus14 merged 5 commits into
NVIDIA:mainfrom
msaroufim:lint
Apr 29, 2025
Merged

Add lint instructions#581
kkraus14 merged 5 commits into
NVIDIA:mainfrom
msaroufim:lint

Conversation

@msaroufim

@msaroufimmsaroufim commented Apr 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add instructions on how to lint the repo for new contributors

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Apr 25, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@msaroufimmsaroufim changed the title lintAdd lint instructionsApr 25, 2025
Mark Saroufim
signoff
880fa9a
Signed-off-by: Mark Saroufim <marksaroufim@meta.com>
@leofangleofang added documentation Improvements or additions to documentation support All things related to the project that can't be categorized P1 Medium priority - Should do blocked This task is currently blocked by other tasks labels Apr 26, 2025
@leofangleofang added this to the cuda.core beta 4 milestone Apr 26, 2025
@leofangleofang removed the blocked This task is currently blocked by other tasks label Apr 28, 2025
@leofang
leofang requested review from rwgk and vzhurba01April 29, 2025 01:19
rwgk
rwgk reviewed Apr 29, 2025
View reviewed changes
Comment threadCONTRIBUTING.md Outdated
@vzhurba01vzhurba01 mentioned this pull request Apr 29, 2025
Merged
2 tasks
@msaroufim
msaroufim requested a review from rwgkApril 29, 2025 18:09
@kkraus14

kkraus14 commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Skipping CI as it's a markdown only change. Thanks @msaroufim!

@kkraus14
kkraus14 merged commit 9e868ba into NVIDIA:mainApr 29, 2025
@github-actions

github-actionsBot commented Apr 29, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 approved these changes
@vzhurba01vzhurba01Awaiting requested review from vzhurba01
@rwgkrwgkAwaiting requested review from rwgk

Assignees

No one assigned

Labels

documentationImprovements or additions to documentationP1Medium priority - Should dosupportAll things related to the project that can't be categorized

Projects

None yet

Milestone

cuda.core beta 4

Development

Successfully merging this pull request may close these issues.

4 participants

@msaroufim@kkraus14@rwgk@leofang