Uh oh!
There was an error while loading. Please reload this page.
CI: Always fetch the compute-sanitizer from the CTK 12.8.0 - #593
Merged
Conversation
Contributor
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
carterbox
commented
Apr 30, 2025
ContributorAuthor
/ok to test b86f71c |
carterbox
commented
Apr 30, 2025
ContributorAuthor
Probably need to change the modules list so that we have a cache miss. |
carterbox
commented
Apr 30, 2025
ContributorAuthor
/ok to test b22711c |
2 tasks
carterbox
commented
Apr 30, 2025
ContributorAuthor
Closing in favor of different approach #594 |
This comment has been minimized.
This comment has been minimized.
leofang
commented
May 1, 2025
Member
Let me reopen this and look into it further |
leofang
reviewed
May 1, 2025
leofang
left a comment
Member
There was a problem hiding this comment.
Let me purge the cache again and try this.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
May 1, 2025
Member
/ok to test 28b585b |
leofang
approved these changes
May 1, 2025
rwgk
approved these changes
May 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
May 1, 2025
Member
Let's merge for now. |
|
leofang added a commit
that referenced
this pull request
May 3, 2025
* CI: Install latest compute-sanitizer separately from CTK * Use mkdir -p to reuse CUDA_PATH * BUG: Always start with clean CUDA_PATH when building cache * REF: Setup CUDA component cache in TMP directory Prevent collision with components already installed to the CUDA_PATH * DEV: Skip non python-3.12 for debugging * fix * Revert "Merge pull request #593 from carterbox/dching/latest-sanitizer" This reverts commit bd770e1, reversing changes made to 19df0d9. * use guess_latest.sh to get the latest CTK ver * fix cache restoration * fix cache restoration * guess_latest needs wget * dunno what I was thinking * not sure if this would work on git for windows... * fix * give rsync a shot * debug * trailing slash, it's always the trailing slash * for some reason --strip-components=1 does not work... * the test runners do not have rsync * restore full matrix * move * avoid rsync... * fix * add inline comments --------- Co-authored-by: Leo Fang <leof@nvidia.com> Co-authored-by: Leo Fang <leo80042@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to always use the latest compute-sanitizer because there could be bug fixes for the compute-sanitizer, and it is OK to use the newest compute-sanitizer on programs running with old CTK versions.
closes#594
Checklist