Skip to content

Implement device and context properties for Event - #618

Merged
leofang merged 10 commits into
NVIDIA:mainfrom
NaderAlAwar:event-inverse-lookup
May 21, 2025
Merged

Implement device and context properties for Event#618
leofang merged 10 commits into
NVIDIA:mainfrom
NaderAlAwar:event-inverse-lookup

Conversation

@NaderAlAwar

Copy link
Copy Markdown
Contributor

Description

closes#491

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang
leofang self-requested a review May 7, 2025 17:34
@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels May 7, 2025
@leofangleofang added this to the cuda.core beta 4 milestone May 7, 2025
Comment threadcuda_core/cuda/core/experimental/_event.py Outdated
Comment threadcuda_core/cuda/core/experimental/_event.py
Comment threadcuda_core/tests/test_event.py Outdated
@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@NaderAlAwar

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang

Copy link
Copy Markdown
Member

LGTM! Let's add a release note entry to 0.3.0

@NaderAlAwar
NaderAlAwar requested a review from leofangMay 21, 2025 13:02
@leofang

Copy link
Copy Markdown
Member

Thanks, Nader! Since the CI was green, let me admin-merge.

@leofang
leofang merged commit ed884c9 into NVIDIA:mainMay 21, 2025
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.coreEverything related to the cuda.core moduleenhancementAny code-related improvementsP1Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event should provide an inverse lookup to its origin Device/Context

3 participants

@NaderAlAwar@leofang@rwgk