Uh oh!
There was an error while loading. Please reload this page.
Move dependencies from requirements.txt to an optional packaging extra - #638
Conversation
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Keith Kraus <keith.j.kraus@gmail.com>
kkraus14
commented
May 15, 2025
/ok to test |
This comment has been minimized.
This comment has been minimized.
…ies as well Signed-off-by: Keith Kraus <keith.j.kraus@gmail.com>
kkraus14
commented
May 15, 2025
/ok to test |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Leo Fang <leo80042@gmail.com>
| "numpy>=1.21.1", | ||
| "pytest>=6.2.4", | ||
| "pytest-benchmark>=3.4.1", | ||
| "llvmlite" |
There was a problem hiding this comment.
Looks good to me, but just to point out our options:
- This could be left commented out (status quo), with
# Uncomment to generate MINIMAL_NVVMIR_BITCODE_STATIC for test_nvvm.py (see PR #443).
- If we choose to make this an unconditional
testdependency: I'll work on a follow-on PR to simplify the logic incuda_bindings/tests/test_nvvm.py. I believe we can then remove theMINIMAL_NVVMIR_BITCODE_STATICdictionary entirely.
There was a problem hiding this comment.
This is something I wanted to discuss. I could pull it out into a separate optional dependency group of something like test-nvvm or something of the likes. One of my motivations for uncommenting it was to have it start being tested in CI.
There was a problem hiding this comment.
My vote, based on the quick experiment below (pip install llvmlite takes less than 1 second):
- Make
llvmlitean unconditionaltestdependency, as you have it right now. - I'll do the follow-on PR (quickly, should be easy to squeeze in).
0db6015-lcedt.nvidia.com:~ $ python -m venv junk
0db6015-lcedt.nvidia.com:~ $ . junk/bin/activate
(junk) 0db6015-lcedt.nvidia.com:~ $ pip install --upgrade pip
...
Successfully installed pip-25.1.1
(junk) 0db6015-lcedt.nvidia.com:~ $ time pip install llvmlite
Collecting llvmlite
Using cached llvmlite-0.44.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (5.0 kB)
Using cached llvmlite-0.44.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (42.4 MB)
Installing collected packages: llvmlite
Successfully installed llvmlite-0.44.0
real 0m0.867s
user 0m0.662s
sys 0m0.151s
kkraus14
commented
May 15, 2025
/ok to test |
kkraus14
commented
May 15, 2025
/ok to test |
kkraus14
commented
May 15, 2025
/ok to test |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
leofang
commented
May 16, 2025
/ok to test |
|
Description
Moves packages needed for testing to an optional dependency group and updates CI and docs to use said optional dependency group. Additionally removes some unused dependencies and specifies versions where they weren't previously specified but were required.
Checklist