Always build and run Cython tests + other CI improvements by leofang · Pull Request #640 · NVIDIA/cuda-python

leofang · 2025-05-16T22:22:35Z

Description

closeCI: Ensure all actions are pinned by commit instead of by version/branch #525
closeCI: Enable Cython tests on Windows runners #466
closeBuild Cython tests as part of build step as opposed to in test steps #639
closeCI: Set up a dependentbot to update GHA versions #644
tentatively pin at cython<3.1.0 (cuda.bindings build time on Linux becomes ~2x slower #642)

Previously, the Cython tests are run on

Latest CUDA 11.x (11.8.0) and 12.x (12.9.0)
Linux only

With this PR, the Cython tests are run on

Latest CUDA 12.x (12.9.0)
Linux and Windows

We can no longer run against the previous major version because of the way of building the Cython tests is changed. It is now built against the build-time CTK, which is always the latest major.minor. But I think this is OK, because the same Cython tests are already run in each major version's branch (example from 11.x).

There is still one open task relevant to Cython tests (#274 (comment)), but the requirement there is likely incompatible with either the old or new approach here and always needs a separate job/workflow, so I consider it out of scope.

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2025-05-16T22:22:38Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

leofang · 2025-05-16T22:22:53Z

/ok to test f0d7333

leofang · 2025-05-16T22:27:30Z

/ok to test 18be719

leofang · 2025-05-16T22:42:21Z

/ok to test c41a39a

leofang · 2025-05-17T02:30:28Z

/ok to test 227e315

leofang · 2025-05-17T02:39:27Z

/ok to test

copy-pr-bot · 2025-05-17T02:39:30Z

/ok to test

@leofang, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

leofang · 2025-05-17T02:39:52Z

/ok to test 9fc20e1

leofang · 2025-05-17T02:51:31Z

/ok to test 512e613

leofang · 2025-05-17T02:56:26Z

/ok to test de4db55

leofang · 2025-05-17T03:00:00Z

/ok to test be78f1b

leofang · 2025-05-17T03:07:08Z

/ok to test a0f964d

leofang · 2025-05-17T03:34:00Z

/ok to test 19e5709

leofang · 2025-05-17T03:48:09Z

/ok to test 78c8afd

leofang · 2025-05-18T22:33:51Z

/ok to test 8f7a054

leofang · 2025-05-18T23:00:10Z

/ok to test 9ad27ac

leofang · 2025-05-18T23:16:09Z

/ok to test 08c5579

leofang · 2025-05-19T00:38:37Z

/ok to test 452fced

leofang · 2025-05-19T01:41:33Z

/ok to test d6ada33

leofang · 2025-05-19T02:02:30Z

/ok to test f5ffde9

leofang · 2025-05-19T03:03:33Z

/ok to test a676eb3a

leofang · 2025-05-19T03:23:44Z

/ok to test f409d19

kkraus14 · 2025-05-19T14:54:28Z

+ run: |
+ pip install $(ls ${{ env.CUDA_CORE_ARTIFACTS_DIR }}/*.whl)[test]
+ pushd ${{ env.CUDA_CORE_CYTHON_TESTS_DIR }}
+ bash build_tests.sh


It would be nice to have these built by a more standard mechanism and avoid needing to run a separate bash script. Any reason we wouldn't want these built when invoking pip install?
Doesn't need to be solved in this PR regardless.

I had the same thought, I have some local changes (started on build) I will rebase once this is merged.

Because I don't want to include the built tests in the wheel. If there is a way to achieve this with the build frontend/backend, it'd certainly simplify build-wheel.yml here, but I couldn't find any.

cryos

LGTM

github-actions · 2025-05-19T15:42:45Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

leofang self-assigned this May 16, 2025

leofang added CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module labels May 16, 2025

leofang force-pushed the cython_test branch from f0d7333 to 18be719Compare May 16, 2025 22:27

try to also build cuda.bindings Cython tests at the build stage
c41a39a

leofang force-pushed the cython_test branch from 18be719 to c41a39aCompare May 16, 2025 22:41

we can no longer lock host Python version
227e315

leofang added 2 commits May 16, 2025 22:37

check if this hack from the test workflow also fixes cibuildwheel
2b38518

also install test deps
9fc20e1

AGENT_TOOLSDIRECTORY needs to be writable
512e613

test
de4db55

test
be78f1b

test
a0f964d

ensure AGENT_TOOLSDIRECTORY is persistent
19e5709

do this instead
78c8afd

fixes
c626592

try this
9ad27ac

again
08c5579

leofang added 2 commits May 18, 2025 20:28

ensure cython tests are only run when testing against build CTK
f589987

try to avoid Cython 3.1 to speed up build time
452fced

leofang added 2 commits May 18, 2025 21:21

pin exact commit for all non-NV GHA
15ac320

move some reusable logics into build_tests.sh
d6ada33

leofang mentioned this pull request May 19, 2025
cuda.bindings build time on Linux becomes ~2x slower #642
Closed

fix path format, again
f5ffde9

leofang added this to the cuda.core beta 4 milestone May 19, 2025

leofang added the P0 High priority - Must do! label May 19, 2025

try enforcing double slashes
f409d19

leofang force-pushed the cython_test branch from a676eb3 to f409d19Compare May 19, 2025 03:23

leofang changed the title ~~Always build and run Cython tests~~Always build and run Cython tests + other CI improvements May 19, 2025

leofang marked this pull request as ready for review May 19, 2025 03:56

leofang requested review from cryos and kkraus14 May 19, 2025 03:56

kkraus14 approved these changes May 19, 2025
View reviewed changes

cryos approved these changes May 19, 2025
View reviewed changes

leofang merged commit 41fdb86 into NVIDIA:mainMay 19, 2025

leofang deleted the cython_test branch May 19, 2025 15:23

leofang mentioned this pull request Jun 12, 2025
Fix release workflow #705
Merged
2 tasks

Uh oh!

Conversation

leofang commented May 16, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

copy-pr-botBot commented May 16, 2025

Uh oh!

leofang commented May 16, 2025

Uh oh!

leofang commented May 16, 2025

Uh oh!

leofang commented May 16, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

copy-pr-botBot commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 17, 2025

Uh oh!

leofang commented May 18, 2025

Uh oh!

leofang commented May 18, 2025

Uh oh!

leofang commented May 18, 2025

Uh oh!

leofang commented May 19, 2025

Uh oh!

leofang commented May 19, 2025

Uh oh!

leofang commented May 19, 2025

Uh oh!

leofang commented May 19, 2025

Uh oh!

leofang commented May 19, 2025

Uh oh!

kkraus14May 19, 2025

Choose a reason for hiding this comment

Uh oh!

cryosMay 19, 2025

Choose a reason for hiding this comment

Uh oh!

leofangMay 19, 2025

Choose a reason for hiding this comment

Uh oh!

cryos left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented May 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leofang commented May 16, 2025•
edited
Loading