Unify Common CI Code for Windows and Linux by cryos · Pull Request #645 · NVIDIA/cuda-python

cryos · 2025-05-19T19:45:23Z

Description

Unify CI code to share common code between different workflows, closes#603.

Checklist

I am familiar with the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2025-05-19T19:45:27Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

cryos · 2025-05-19T19:45:37Z

/ok to test

cryos · 2025-05-19T19:50:39Z

/ok to test

cryos · 2025-05-19T20:01:29Z

/ok to test

cryos · 2025-05-19T20:14:44Z

/ok to test

cryos · 2025-05-19T20:19:02Z

/ok to test

cryos · 2025-05-19T20:48:22Z

/ok to test

cryos · 2025-05-19T21:11:40Z

/ok to test

cryos · 2025-05-19T22:14:13Z

/ok to test

cryos · 2025-05-20T14:35:27Z

/ok to test

cryos · 2025-05-20T15:01:24Z

/ok to test

cryos · 2025-05-20T15:26:08Z

/ok to test

cryos · 2025-05-20T17:16:07Z

/ok to test

cryos · 2025-05-20T18:20:29Z

/ok to test

cryos · 2025-05-20T18:41:13Z

/ok to test

cryos · 2025-05-20T19:11:06Z

/ok to test

leofang · 2025-05-21T00:44:24Z

LGTM so far. I see the assumption here is that the env vars are set in the CI and we just run the scripts, so the scripts are not meant to be run outside of the CI. This is how we avoid param checks (which would add a ton of boilerplates). Let me know whenever you're happy to merge!

cryos · 2025-05-21T16:43:34Z

LGTM so far. I see the assumption here is that the env vars are set in the CI and we just run the scripts, so the scripts are not meant to be run outside of the CI. This is how we avoid param checks (which would add a ton of boilerplates). Let me know whenever you're happy to merge!

Thanks Leo! There are a few other bits I wanted to centralize first, I was proving out that things would work as expected on Windows first. I can split that and merge this if preferred, then create follow ups later to avoid it growing too big.

leofang · 2025-05-21T16:48:51Z

Up to you -- so far I've been able to follow just fine 🙂

leofang · 2025-05-23T14:47:37Z

+ # We don't test compute-sanitizer on CTK<12 because backporting fixes is too much effort
+ # We only test compute-sanitizer on python 3.12 arbitrarily; we don't need to use sanitizer on the entire matrix
+ # Only local ctk installs have compute-sanitizer; there is no wheel for it
+ if [[ "${PY_VER}" == "3.12" && "${CUDA_VER}" != "11.8.0" && "${LOCAL_CTK}" == 1 && "${HOST_PLATFORM}" == linux* ]]; then


Thanks, good catch, this will fix #647.

copy-pr-bot · 2025-05-23T14:54:43Z

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

leofang

LGTM!

leofang · 2025-05-29T23:10:52Z

+ SETUP_SANITIZER=1
+ else
+ SETUP_SANITIZER=0
+ echo "SANITIZER_CMD=" >> $GITHUB_ENV


nit: no need to set it at this stage?

You still want this for workflows that do not call setup-sanitizer as the variable would be unbound. It is nice not to force all workflows to call setup-sanitizer. We can remove it if we have all workflows call the setup, which thinking about it we could just do from the start of run-tests as it relies on the sanitizer stuff being ready there.

github-actions · 2025-05-29T23:37:41Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

Test out a simple env-vars script for build
61e742b

cryos force-pushed the ci-unify-bash branch from ba57a3f to 3510e8fCompare May 19, 2025 19:58

cryos force-pushed the ci-unify-bash branch from 3510e8f to fdc9ab6Compare May 19, 2025 20:14

cryos force-pushed the ci-unify-bash branch from fdc9ab6 to 9d9a018Compare May 19, 2025 20:18

Double quotes to expand out the bash var, separator
3c6da34

cryos force-pushed the ci-unify-bash branch from 9d9a018 to 3c6da34Compare May 19, 2025 20:48

This comment has been minimized.
Sign in to view

cryos force-pushed the ci-unify-bash branch from 7d92e80 to bbe101bCompare May 19, 2025 22:13

cryos added the CI/CD CI/CD infrastructure label May 19, 2025

cryos force-pushed the ci-unify-bash branch from bbe101b to 1cc791dCompare May 20, 2025 14:35

cryos force-pushed the ci-unify-bash branch from 1cc791d to 22d7ed0Compare May 20, 2025 14:59

Reuse env var code in the tests, add test runner
91c07c9

cryos force-pushed the ci-unify-bash branch from 22d7ed0 to 91c07c9Compare May 20, 2025 15:25

cryos force-pushed the ci-unify-bash branch from d36b17c to 4695afeCompare May 20, 2025 18:20

cryos force-pushed the ci-unify-bash branch from 4695afe to a81c7aaCompare May 20, 2025 18:41

Simplify compute-sanitizer setup, fix bindings name
bbeb011

cryos force-pushed the ci-unify-bash branch from a81c7aa to bbeb011Compare May 20, 2025 19:10

leofang assigned cryos May 20, 2025

leofang added this to the cuda.core beta 4 milestone May 20, 2025

leofang added the P1 Medium priority - Should do label May 20, 2025

cryos changed the title ~~Test out a simple env-vars script for build~~Unify Common CI Code for Windows and LinuxMay 20, 2025

leofang added the enhancement Any code-related improvements label May 21, 2025

leofang reviewed May 23, 2025
View reviewed changes

leofang linked an issue May 23, 2025 that may be closed by this pull request
CI: compute-sanitizer package is not correctly cached #647
Closed

cryos marked this pull request as ready for review May 23, 2025 14:54

cryos requested a review from leofang May 23, 2025 14:55

leofang approved these changes May 29, 2025
View reviewed changes

leofang merged commit d1c8b0f into NVIDIA:mainMay 29, 2025

Uh oh!

Conversation

cryos commented May 19, 2025

Description

Checklist

Uh oh!

copy-pr-botBot commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

cryos commented May 19, 2025

Uh oh!

This comment has been minimized.

cryos commented May 19, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

cryos commented May 20, 2025

Uh oh!

leofang commented May 21, 2025

Uh oh!

cryos commented May 21, 2025

Uh oh!

leofang commented May 21, 2025

Uh oh!

leofangMay 23, 2025

Choose a reason for hiding this comment

Uh oh!

copy-pr-botBot commented May 23, 2025

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

leofangMay 29, 2025

Choose a reason for hiding this comment

Uh oh!

cryosMay 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented May 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants