Uh oh!
There was an error while loading. Please reload this page.
Repair Windows wheels - #673
Merged
Merged
Conversation
Contributor
leofang
commented
Jun 2, 2025
MemberAuthor
/ok to test 375ff35 |
leofang
commented
Jun 2, 2025
MemberAuthor
/ok to test fcaefe4 |
This comment has been minimized.
This comment has been minimized.
leofang
marked this pull request as ready for review
June 4, 2025 03:38
kkraus14
approved these changes
Jun 4, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We could be using a new VS toolchain to build wheels soon (#672). We want to make sure the Windows wheels still can be used by older Windows env (as old as those supported by CUDA 12.0), and repairing the wheels is a way to do so.
Checklist