Uh oh!
There was an error while loading. Please reload this page.
Clean up cffi resources in file - #679
Merged
leofang merged 4 commits intoJun 5, 2025
Merged
Conversation
Contributor
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
oleksandr-pavlyk
requested review from
leofang and rwgk
and removed request for
rwgkJune 4, 2025 17:28
oleksandr-pavlyk
commented
Jun 4, 2025
ContributorAuthor
/ok to test |
This comment has been minimized.
This comment has been minimized.
Make sure to del cpu_func and my_func that references it.
leofang
reviewed
Jun 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
oleksandr-pavlyk
commented
Jun 5, 2025
ContributorAuthor
/ok to test |
leofang
approved these changes
Jun 5, 2025
leofang
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing the temporary file issue and cleaning up the example!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closesgh-535
This PR removes fixture
clean_up_cffi_filesand add logic forexamples/strided_memory_view.pyto create temporary directory, compile CPU extension in it, import, execute, and clean-up artifacts and the temporary directory in the example.Furthermore, GPU example is modified to make sure that stream is closed even if error occurred during GPU example execution.
Checklist