Skip to content

Allow ObjectCode to have a name - #682

Merged
leofang merged 5 commits into
NVIDIA:mainfrom
leofang:names
Jun 6, 2025
Merged

Allow ObjectCode to have a name#682
leofang merged 5 commits into
NVIDIA:mainfrom
leofang:names

Conversation

@leofang

@leofangleofang commented Jun 5, 2025

Copy link
Copy Markdown
Member

Description

Close#506. Close#662.

ObjectCode can be named in all cases:

  • if generated by Program.compile(), passed through the program option
  • if generated by Linker.link(), passed through the linker option
  • if created via alternative constructors, passed through the constructor argument

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofangleofang added this to the cuda.core beta 4 milestone Jun 5, 2025
@leofangleofang added P1 Medium priority - Should do feature New feature or request cuda.core Everything related to the cuda.core module labels Jun 5, 2025
@copy-pr-bot

copy-pr-botBot commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Jun 5, 2025

Copy link
Copy Markdown
MemberAuthor

@brandon-b-miller could you check if this meets Numba-cuda's needs?

@leofangleofang self-assigned this Jun 5, 2025
@leofang

leofang commented Jun 5, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test f72b1c0

@leofangleofang mentioned this pull request Jun 5, 2025
Merged
@github-actions

This comment has been minimized.

Sign in to view
@brandon-b-miller

brandon-b-miller commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Hi @leofang , with this branch and NVIDIA/numba-cuda@4fad9f3 the last failing test is now a pass for me locally.

kkraus14
kkraus14 previously approved these changes Jun 6, 2025
View reviewed changes
@github-project-automationgithub-project-automationBot moved this from Todo to In Review in CCCLJun 6, 2025
@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test be63566

@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test c8572b2

kkraus14
kkraus14 previously approved these changes Jun 6, 2025
View reviewed changes
@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

Looks like we have a race here 😛 Since the CI was green and Keith approved, and I only merged the main branch to resolve a conflict in the release note, let me admin-merge.

@leofang
leofang merged commit 9ef1562 into NVIDIA:mainJun 6, 2025
@github-project-automationgithub-project-automationBot moved this from In Review to Done in CCCLJun 6, 2025
@leofang
leofang deleted the names branch June 6, 2025 13:43
@github-actions

github-actionsBot commented Jun 6, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 left review comments

Assignees

@leofangleofang

Labels

cuda.coreEverything related to the cuda.core modulefeatureNew feature or requestP1Medium priority - Should do

Projects

CCCL
Archived in project

Milestone

cuda.core beta 4

Development

Successfully merging this pull request may close these issues.

[FEA]: Allow specifying the names of inputs to the Linker Support custom naming of nvrtc programs

3 participants

@leofang@brandon-b-miller@kkraus14