Skip to content

Make compute-sanitizer not report API errors as errors - #687

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
leofang:no_api_err
Jun 7, 2025
Merged

Make compute-sanitizer not report API errors as errors#687
leofang merged 2 commits into
NVIDIA:mainfrom
leofang:no_api_err

Conversation

@leofang

@leofangleofang commented Jun 6, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Description

We rely on driver/runtime to report API errors to us for decision making and input checking (#685). If the compute-sanitizer keeps treating API errors as real errors, we end up skipping the majority of the test suite. Before the sanitizer can suppress errors on a per-API basis, we turn --report-api-errors off globally.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofangleofang added this to the cuda.core beta 4 milestone Jun 6, 2025
@leofangleofang self-assigned this Jun 6, 2025
@leofangleofang added P0 High priority - Must do! test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module labels Jun 6, 2025
@leofangleofang added the cuda.core Everything related to the cuda.core module label Jun 6, 2025
@copy-pr-bot

copy-pr-botBot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

/ok to test 1d32e14

@github-actions

github-actionsBot commented Jun 6, 2025

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-687/

https://nvidia.github.io/cuda-python/pr-preview/pr-687/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-687/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang

leofang commented Jun 6, 2025

Copy link
Copy Markdown
MemberAuthor

cc @carterbox for vis

@leofang
leofang requested a review from rwgkJune 7, 2025 00:40
@leofang
leofang marked this pull request as ready for review June 7, 2025 00:40
@leofangleofang mentioned this pull request Jun 7, 2025
Merged
@github-project-automationgithub-project-automationBot moved this from Todo to In Review in CCCLJun 7, 2025
@leofang

leofang commented Jun 7, 2025

Copy link
Copy Markdown
MemberAuthor

Since the CI was green and the last commit was largely innocent, let me admin-merge and test it in the other PR. Thanks, Keith!

@leofang
leofang merged commit a253674 into NVIDIA:mainJun 7, 2025
@github-project-automationgithub-project-automationBot moved this from In Review to Done in CCCLJun 7, 2025
@leofang
leofang deleted the no_api_err branch June 7, 2025 01:16
@leofangleofang mentioned this pull request Jun 26, 2025
Closed
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 approved these changes
@rwgkrwgkAwaiting requested review from rwgk

Assignees

@leofangleofang

Labels

cuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core moduleP0High priority - Must do!testImprovements or additions to tests

Projects

CCCL
Archived in project

Milestone

cuda.core beta 4

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@kkraus14