Skip to content

Restore option to run testing without cupy installed. - #741

Merged
rwgk merged 1 commit into
NVIDIA:mainfrom
rwgk:cuda_core_cupy_skip
Jul 1, 2025
Merged

Restore option to run testing without cupy installed.#741
rwgk merged 1 commit into
NVIDIA:mainfrom
rwgk:cuda_core_cupy_skip

Conversation

@rwgk

@rwgkrwgk commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Description

cuda_core is generally set up to run most tests without cupy installed.

PR #717 added one unconditional cupy import. This PR adopts the approach in tests/test_utils.py for the import in tests/test_launcher.py, and copies the SKIPPED message from tests/example_tests/utils.py.

@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Jul 1, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

@rwgk
rwgk marked this pull request as ready for review July 1, 2025 07:24
@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk
rwgk requested a review from shwinaJuly 1, 2025 07:25
@github-project-automationgithub-project-automationBot moved this from Todo to In Review in CCCLJul 1, 2025
@leofangleofang added P1 Medium priority - Should do test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Jul 1, 2025
@rwgk

rwgk commented Jul 1, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @leofang

@rwgk
rwgk merged commit 5576da6 into NVIDIA:mainJul 1, 2025
56 checks passed
@github-project-automationgithub-project-automationBot moved this from In Review to Done in CCCLJul 1, 2025
@rwgk
rwgk deleted the cuda_core_cupy_skip branch July 1, 2025 11:31
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofangleofang added this to the cuda.core beta 5 milestone Jul 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.coreEverything related to the cuda.core moduleP1Medium priority - Should dotestImprovements or additions to tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@leofang