Skip to content

Fix CI build-time parallelism + support the same env var in cuda.core - #743

Merged
leofang merged 3 commits into
NVIDIA:mainfrom
leofang:fix_nproc
Jul 2, 2025
Merged

Fix CI build-time parallelism + support the same env var in cuda.core#743
leofang merged 3 commits into
NVIDIA:mainfrom
leofang:fix_nproc

Conversation

@leofang

Copy link
Copy Markdown
Member

Description

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang
leofang requested a review from cryosJuly 2, 2025 03:16
@leofangleofang self-assigned this Jul 2, 2025
@leofangleofang added P0 High priority - Must do! CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Jul 2, 2025
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofangleofang changed the title Fix CI build-time parallelim + support the same env var in cuda.coreFix CI build-time parallelism + support the same env var in cuda.coreJul 2, 2025
@leofang

Copy link
Copy Markdown
MemberAuthor

pre-commit.ci autofix

@leofang

Copy link
Copy Markdown
MemberAuthor

/ok to test 11796bc

@leofangleofang added the bug Something isn't working label Jul 2, 2025
@github-actions

This comment has been minimized.

@leofang

Copy link
Copy Markdown
MemberAuthor

I eyeballed the build time change (against the main branch) and observed noticeable speedup!

Comment threadcuda_core/setup.py
@leofang

Copy link
Copy Markdown
MemberAuthor

Let me admin-merge here. I need this in to study if we can relax Cython upper bound.

@leofang
leofang merged commit 916097e into NVIDIA:mainJul 2, 2025
54 checks passed
@github-project-automationgithub-project-automationBot moved this from Todo to Done in CCCLJul 2, 2025
@leofang
leofang deleted the fix_nproc branch July 2, 2025 22:56
@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingCI/CDCI/CD infrastructurecuda.bindingsEverything related to the cuda.bindings modulecuda.coreEverything related to the cuda.core moduleP0High priority - Must do!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@rwgk