Uh oh!
There was an error while loading. Please reload this page.
_cuda_bindings_redirector.py fix (made necessary by PR #773) - #780
Conversation
… suggested by ChatGPT) to resolveNVIDIA#773 (comment)
…p error Previously, the `_cuda_bindings_redirector.py` file imported `cuda.bindings` at interpreter startup to ensure the `cuda` namespace was initialized. However, this triggered early loading of Cython modules that depend on `win32api`, which may not be available yet due to `.pth` file processing order. This commit replaces `import cuda.bindings` with `import cuda`, which is sufficient to ensure the `cuda` namespace is in `sys.modules`. The version redirect via `cuda.__version__` is preserved by assigning a custom `LazyCudaModule` type to `sys.modules["cuda"]`. As a result, `cuda.__version__` continues to work (with a deprecation warning), while avoiding startup errors when `win32api` is not yet importable.
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rwgk
commented
Jul 24, 2025
@leofang for visibility |
rwgk
commented
Jul 24, 2025
/ok to test |
|
rwgk
commented
Jul 24, 2025
@kkraus14@oleksandr-pavlyk@leofang I asked ChatGPT about Look for "Why might the original author have used import cuda.bindings" The conclusion there:
All tests pass, so I think this super easy fix is all we need. |
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rwgk
commented
Jul 24, 2025
I forgot to add: I downloaded the CI logs and searched for |
leofang
left a comment
There was a problem hiding this comment.
Thanks, Ralf. The fix looks reasonable to me. Unfortunately I can't reliably reproduce the issue, so if it fixes on your side it should be good enough, and let's merge and monitor the situation.
Avoid premature import of
cuda.bindingsin redirector to fix startup noise (see here).Previously, the
_cuda_bindings_redirector.pyfile importedcuda.bindingsat interpreter startup to ensure thecudanamespace was initialized. However, this triggered early loading of Cython modules that depend onwin32api, which may not be available yet due to.pthfile processing order.This commit replaces
import cuda.bindingswithimport cuda, which is sufficient to ensure thecudanamespace is insys.modules. The version redirect viacuda.__version__is preserved by assigning a customLazyCudaModuletype tosys.modules["cuda"].As a result,
cuda.__version__continues to work (with a deprecation warning), while avoiding startup errors whenwin32apiis not yet importable.