Skip to content

Backport test_cufile.py changes (from unreleased branch). - #783

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
rwgk:test_cufile_fix
Aug 4, 2025
Merged

Backport test_cufile.py changes (from unreleased branch).#783
leofang merged 2 commits into
NVIDIA:mainfrom
rwgk:test_cufile_fix

Conversation

@rwgk

@rwgkrwgk commented Jul 27, 2025

Copy link
Copy Markdown
Contributor

This diff (commit b2239c1)

-@pytest.fixture(scope="module")+@pytest.fixture

fixes an issue encountered while testing against an unreleased branch.

Commit c67f4ac was added to reduce pytest output when the original assert failed.

@copy-pr-bot

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk

rwgk commented Jul 27, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@rwgk

rwgk commented Jul 27, 2025

Copy link
Copy Markdown
ContributorAuthor

Close-Reopen to retrigger CI (after a weird git clone failure).

@rwgkrwgk closed this Jul 27, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in CCCLJul 27, 2025
@rwgkrwgk reopened this Jul 27, 2025
@github-project-automationgithub-project-automationBot moved this from Done to Needs Triage in CCCLJul 27, 2025
@rwgk

rwgk commented Jul 27, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

@rwgkrwgk self-assigned this Jul 28, 2025
@rwgk

rwgk commented Jul 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@sourabgupta3

Comment threadcuda_bindings/tests/test_cufile.py
@github-project-automationgithub-project-automationBot moved this from Needs Triage to In Review in CCCLAug 4, 2025
@leofangleofang added bug Something isn't working P0 High priority - Must do! test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module labels Aug 4, 2025
@leofang

Copy link
Copy Markdown
Member

The check status step failed for some reason and retry does not help. Let's admin-merge and monitor in the main branch.

@leofang
leofang merged commit 926b4e6 into NVIDIA:mainAug 4, 2025
162 of 180 checks passed
@github-project-automationgithub-project-automationBot moved this from In Review to Done in CCCLAug 4, 2025
@rwgk

rwgk commented Aug 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Ah, thanks for merging!

I was just about to write: The Close-Reopen step (#783 (comment)) seems to have tripped up the job harvesting the build and test results.

@rwgk
rwgk deleted the test_cufile_fix branch August 4, 2025 16:08
@leofang

Copy link
Copy Markdown
Member

Interesting... first time hitting this weird issue

btw @rwgk no need to backport this PR to the 12.9.x branch manually. Once #792 is merged I'd like to test the backport bot with this PR.

@github-actions

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingcuda.bindingsEverything related to the cuda.bindings moduleP0High priority - Must do!testImprovements or additions to tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@rwgk@leofang