Skip to content

getting started example is complete - #797

Merged
leofang merged 2 commits into
NVIDIA:mainfrom
richardhboyd:fix_example
Aug 6, 2025
Merged

getting started example is complete#797
leofang merged 2 commits into
NVIDIA:mainfrom
richardhboyd:fix_example

Conversation

@richardhboyd

@richardhboydrichardhboyd commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

Description

issue

I added the import for cupy and initialized the RNG so that the getting started example works if a user copies each snippet from the docs into an appropriate environment

Checklist

  • I am familiar with the Contributing Guidelines.
  • [N/A] New or existing tests cover these changes. (I didn't see any tests for the documentation other than just building it)
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@richardhboyd

richardhboyd commented Aug 5, 2025

Copy link
Copy Markdown
ContributorAuthor

apologies for the force-pushes, I was trying to fix my GPG signature. it should be all good now.

@leofang
leofang requested a review from shwinaAugust 5, 2025 01:45
@leofangleofang added documentation Improvements or additions to documentation P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Aug 5, 2025
@leofangleofang added this to the cuda.core beta 6 milestone Aug 5, 2025
shwina
shwina approved these changes Aug 5, 2025
View reviewed changes

@shwinashwina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks so much @richardhboyd !

@github-project-automationgithub-project-automationBot moved this from Todo to In Review in CCCLAug 5, 2025
@shwina

shwina commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

/ok to test cb0fa67

@github-actions

github-actionsBot commented Aug 5, 2025

Copy link
Copy Markdown
Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-797/

https://nvidia.github.io/cuda-python/pr-preview/pr-797/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-797/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang

leofang commented Aug 5, 2025

Copy link
Copy Markdown
Member

FYI we are fixing the CI failures as part of #792.

@leofang

leofang commented Aug 6, 2025

Copy link
Copy Markdown
Member

/ok to test b8ab24c

@leofang
leofang enabled auto-merge (squash) August 6, 2025 15:33
@leofangleofang linked an issue Aug 6, 2025 that may be closed by this pull request
[DOC]: 'Getting started' example does not run as documented #796
Closed
1 task
@leofang
leofang merged commit efa91a6 into NVIDIA:mainAug 6, 2025
49 checks passed
@github-project-automationgithub-project-automationBot moved this from In Review to Done in CCCLAug 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwinashwinashwina approved these changes

Assignees

No one assigned

Labels

cuda.coreEverything related to the cuda.core moduledocumentationImprovements or additions to documentationP1Medium priority - Should do

Projects

CCCL
Archived in project

Milestone

cuda.core beta 6

Development

Successfully merging this pull request may close these issues.

[DOC]: 'Getting started' example does not run as documented

3 participants

@richardhboyd@shwina@leofang