Skip to content

[Backport] Remove trampoline modules - #807

Closed
leofang wants to merge 1 commit into
NVIDIA:12.9.xfrom
leofang:bp_trampoline
Closed

[Backport] Remove trampoline modules#807
leofang wants to merge 1 commit into
NVIDIA:12.9.xfrom
leofang:bp_trampoline

Conversation

@leofang

@leofangleofang commented Aug 6, 2025

Copy link
Copy Markdown
Member

Description

Manual backport of #795

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofangleofang added this to the cuda-python 13.0.0 & 12.9.1 milestone Aug 6, 2025
@leofang
leofang requested review from kkraus14 and rwgkAugust 6, 2025 16:42
@leofangleofang self-assigned this Aug 6, 2025
@leofangleofang added P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module breaking Breaking changes are introduced labels Aug 6, 2025
@copy-pr-bot

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bdice

bdice commented Aug 6, 2025

Copy link
Copy Markdown

Just for awareness, I unexpectedly saw these warnings the other day while trying out LLM NIMs for the first time. Not to dissuade you -- I think you can justify the change based on the length of deprecation -- but I think there are a lot of users who haven't migrated and this could have wider repercussions than anticipated.

Example of where I saw this: https://gist.github.com/bdice/1de237b48370a29ef9d5c777ac2acc5e#file-gpt-oss-20b-log-L55

@leofang

Copy link
Copy Markdown
MemberAuthor

Based on an offline discussion with Bradley/Keith based on the above observation, we decided to not purge the trampolines in 12.9.x.

@leofangleofang closed this Aug 6, 2025
@github-project-automationgithub-project-automationBot moved this from Todo to Done in CCCLAug 6, 2025
@leofang
leofang deleted the bp_trampoline branch August 6, 2025 17:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingBreaking changes are introducedcuda.bindingsEverything related to the cuda.bindings moduleP0High priority - Must do!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants

@leofang@bdice