Adds path for the CUDA static library based on CUDA_HOME

[Andy-Jost]

Both CUDA_HOME (or CUDA_PATH) and LIBRARY_PATH are required to be set in the environment during installation. There was already a check for CUDA_HOME in setup.py, but no check for LIBRARY_PATH. This change adds a check to make sure LIBRARY_PATH is set.

When LIBRARY_PATH is not set, the installation fails at link time and indicates that cudart_static could not be found.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[kkraus14]

@Andy-Jost to trigger CI to run you need to comment "/ok to test". More info here: https://docs.gha-runners.nvidia.com/platform/apps/copy-pr-bot/faqs

[Andy-Jost]

/ok to test 6b178c1a24971ef7811dc4571cb08295a3956b7b

[Andy-Jost]

This breaks Windows builds because LIBRARY_PATH is specific to Linux. While I could place a guard around the check, it's probably better to close this PR without merging.

[rwgk]

This breaks Windows builds because LIBRARY_PATH is specific to Linux. While I could place a guard around the check, it's probably better to close this PR without merging.

I think it'd be lovely to complete this PR, I stumbled over this many times.

Under Windows, we need LIB to be set.

This is a good way to test for Windows (we use that in cuda_pathfinder):

IS_WINDOWS = sys.platform == "win32"

[Andy-Jost]

This breaks Windows builds because LIBRARY_PATH is specific to Linux. While I could place a guard around the check, it's probably better to close this PR without merging.

I think it'd be lovely to complete this PR, I stumbled over this many times.

Under Windows, we need LIB to be set.

This is a good way to test for Windows (we use that in cuda_pathfinder):

IS_WINDOWS = sys.platform == "win32"

I am looking into a solution that works for Windows as well as Linux.

[leofang]

Probably just update library_dirs that's passed to setup() in setup.py?

[Andy-Jost]

The latest changes eliminate the need to set either LIBRARY_PATH or LIB and should resolve issue #608.

Where can I find the source for the installation instructions? I.e., https://nvidia.github.io/cuda-python/cuda-bindings/latest/install.html.

Those can be updated now.

[Andy-Jost]

Probably just update library_dirs that's passed to setup() in setup.py?

This did the trick.

[Andy-Jost]

/ok to test 96f3514f3ace9fdc505165add1f65ac52cbc970b

[leofang]

Thanks, @Andy-Jost! The diff is clean now.

I think to test this properly in the CI, we should delete these two lines

cuda-python/.github/workflows/build-wheel.yml

Line 160 in b400e34

LIBRARY_PATH=/host/${{ env.CUDA_PATH }}/lib

cuda-python/.github/workflows/build-wheel.yml

Line 164 in b400e34

LIB="${CUDA_HOME}\\lib\\x64;${LIB}"

Not sure if I miss any. I hope not 🤔

[leofang]

On the Linux side, one annoying thing is that depending on how CUDA is installed, this could be lib or lib64:

$ ls -l /usr/local/cuda-13.0/lib64/libcudart_static.a -rw-r--r-- 1 root root 1361104 Aug 5 09:32 /usr/local/cuda-13.0/lib64/libcudart_static.a
$ ls -l /usr/local/cuda-13.0/targets/x86_64-linux/lib/libcudart_static.a -rw-r--r-- 1 root root 1361104 Aug 5 09:32 /usr/local/cuda-13.0/targets/x86_64-linux/lib/libcudart_static.a

https://github.com/conda-forge/cuda-cudart-feedstock/blob/38fb08899691fa53fce33960ef37d48ab58584b0/recipe/meta.yaml#L220

https://github.com/conda-forge/cuda-cudart-feedstock/blob/38fb08899691fa53fce33960ef37d48ab58584b0/recipe/meta.yaml#L251

We probably should support both.

[Andy-Jost]

/ok to test 19aaca9358742cb4913c6e138b0f9c28c6b0744d

[Andy-Jost]

I see a failure in pre-commit.ci due to "ruff format" creating diffs. I think I get the general idea, but I don't see how to get more information (e.g., see the diffs, or run the ruff format locally). I can probably fix the formatting issue by guessing, but in general how can I get the details?

[Andy-Jost]

/ok to test 19aaca9358742cb4913c6e138b0f9c28c6b0744d

[Andy-Jost]

/ok to test 26da853a3bb600112694a26248c5399a9347446e

[Andy-Jost]

/ok to test 73acddf

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.

[leofang]

@copilot please backport this PR to the 12.9.x branch. (Since this PR touched some files in the .github folder, the backport bot does not work.)

[github-actions]

Git push to origin failed for 12.9.x with exitcode 1

[github-actions]

Git push to origin failed for 12.9.x with exitcode 1