CI: Fix pathfinder CI infrastructure and remove redundant component testing by Copilot · Pull Request #904 · NVIDIA/cuda-python

Copilot · 2025-08-25T22:02:05Z

Fixes#810 by updating both Linux and Windows test workflows to always fetch the cuda-pathfinder wheel from the latest successful run on the main branch, rather than from the current branch's build artifacts. Additionally removes redundant testing of components that are not actively maintained in this branch.

Problem

The current CI design has issues with outdated artifacts and redundant testing:

Outdated pathfinder artifacts: The 12.9.x branch test workflows download cuda-pathfinder from the same branch as other components. However, cuda-pathfinder is only actively maintained on the main branch, so using artifacts from the 12.9.x branch could lead to outdated or inconsistent pathfinder functionality.
Redundant component testing: The workflows run tests for cuda-pathfinder and cuda.core on backport branches, but since these components are only developed on main, these tests are redundant and don't add value.

Solution

This PR modifies both test-wheel-linux.yml and test-wheel-windows.yml to:

Replace the existing artifact download step for cuda-pathfinder with new steps that fetch from the main branch
Follow the existing pattern used by the "Download cuda-python & cuda.bindings build artifacts from the prior branch" steps
Ensure cross-platform compatibility with proper bash/PowerShell implementations
Remove all pathfinder and cuda.core test steps since the focus should be on ensuring cuda.bindings 12.x works correctly with the latest versions of these components, not testing them independently

The new pathfinder download steps:

Install GitHub CLI if not available
Query the latest successful CI run on the main branch
Download the cuda-pathfinder-wheel artifact from that run
Place it in the expected ./cuda_pathfinder directory

Key Features

Consistent behavior: Both workflows now guarantee they use the same, up-to-date pathfinder from main
Focused testing: Removed redundant component tests; workflows focus on cuda.bindings compatibility with latest versions
Error handling: Proper validation that the latest run ID is found before attempting download
Backward compatibility: Maintains the same directory structure expected by downstream workflow steps
Follows existing patterns: Uses the same approach as the existing cross-branch artifact fetching logic

This change ensures that 12.9.x branch testing always uses the maintained implementations from main for compatibility testing with cuda.bindings, while eliminating redundant testing and the risk of using stale code from components not maintained in this branch.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

copy-pr-bot · 2025-08-25T22:02:09Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

leofang

@copilot

leofang · 2025-08-25T22:25:19Z

@copilot address the comments above

Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

Copilot · 2025-08-25T22:29:51Z

@copilot address the comments above

Addressed both comments: consolidated GitHub CLI installation in Linux workflow (removed duplication) and fixed step ordering in Windows workflow to ensure gh is available before pathfinder download. Changes made in commit c110dcf.

leofang · 2025-08-25T22:34:34Z

/ok to test c110dcf

leofang · 2025-08-25T22:55:44Z

@copilot please remove all pathfinder test steps from the test workflows. As mentioned we only develop (and thus) pathfinder on the main branch. So for the backport branch, the focus is to ensure cuda.bindings 12.x can run correctly with the latest pathfinder.

Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

Copilot · 2025-08-25T23:03:17Z

@copilot please remove all pathfinder test steps from the test workflows. As mentioned we only develop (and thus) pathfinder on the main branch. So for the backport branch, the focus is to ensure cuda...

Removed all pathfinder test steps from both Linux and Windows test workflows as requested. The workflows now focus on ensuring cuda.bindings 12.x works correctly with the latest pathfinder from main, without redundantly testing pathfinder itself. Fixed in commit 7f46e6c.

leofang · 2025-08-25T23:05:11Z

/ok to test 7f46e6c

leofang · 2025-08-25T23:48:53Z

@copilot for the same reasons, we should remove the cuda.core tests from both test workflows. Only cuda-bindings and cuda-python 12.x are maintained in this branch.

Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

Copilot · 2025-08-25T23:52:12Z

@copilot for the same reasons, we should remove the cuda.core tests from both test workflows. Only cuda-bindings and cuda-python 12.x are maintained in this branch.

Removed all cuda.core test steps from both Linux and Windows test workflows as requested. The workflows now focus only on cuda-bindings and cuda-python 12.x testing, which are the components maintained in this branch. Fixed in commit 402759e.

rwgk

Just a question about a potential simplification. If it looks interesting, we could do that in a separate PR. I see the code is just moved around in this PR.

rwgk · 2025-08-26T14:58:54Z

+ - name: Install GitHub CLI
+ # gh is needed for artifact fetching in subsequent steps
+ run: |
+ # See https://github.com/cli/cli/blob/trunk/docs/install_linux.md#debian-ubuntu-linux-raspberry-pi-os-apt.
+ mkdir -p -m 755 /etc/apt/keyrings \
+ && out=$(mktemp) && wget -nv -O$out https://cli.github.com/packages/githubcli-archive-keyring.gpg \
+ && cat $out | tee /etc/apt/keyrings/githubcli-archive-keyring.gpg > /dev/null \
+ && chmod go+r /etc/apt/keyrings/githubcli-archive-keyring.gpg \
+ && echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null \
+ && apt update \
+ && apt install gh -y


Did you look into using an existing action?
This is from ChatGPT, I didn't try it out:
- name: Setup GitHub CLI uses: actions4gh/setup-gh@v1 with: gh-version: latest # or specify "2.65.0", etc. token: ${{ secrets.GITHUB_TOKEN }}

It seems setup-gh is no longer maintained... 😢 https://github.com/actions4gh/setup-gh

FWIW we already have a install_unix_deps action. Perhaps we could just move this bits there to allow using it to install gh?

leofang · 2025-08-26T17:54:37Z

/ok to test 402759e

Initial plan
61f352c

CopilotAI assigned Copilot and leofang Aug 25, 2025

Update test workflows to fetch cuda-pathfinder from main branch
ad5736b
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

CopilotAI requested a review from leofang August 25, 2025 22:09

leofang requested changes Aug 25, 2025
View reviewed changes

Comment thread.github/workflows/test-wheel-linux.yml Outdated
Comment thread.github/workflows/test-wheel-windows.yml Outdated

Consolidate GitHub CLI installation steps as requested in PR review
c110dcf
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

CopilotAI requested a review from leofang August 25, 2025 22:30

leofang added bug Something isn't working P0 High priority - Must do! CI/CD CI/CD infrastructure cuda.pathfinder Everything related to the cuda.pathfinder module labels Aug 25, 2025

leofang added this to the cuda-python 13-next, 12-next milestone Aug 25, 2025

Remove pathfinder test steps from test workflows
7f46e6c
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

CopilotAI changed the title ~~CI: Fix pathfinder CI infrastructure to fetch from main branch~~CI: Fix pathfinder CI infrastructure and remove redundant pathfinder testingAug 25, 2025

Remove cuda.core test steps from both test workflows
402759e
Co-authored-by: leofang <5534781+leofang@users.noreply.github.com>

CopilotAI changed the title ~~CI: Fix pathfinder CI infrastructure and remove redundant pathfinder testing~~CI: Fix pathfinder CI infrastructure and remove redundant component testingAug 25, 2025

leofang requested review from cryos and rwgk August 26, 2025 00:06

leofang marked this pull request as ready for review August 26, 2025 00:06

rwgk approved these changes Aug 26, 2025
View reviewed changes

leofang approved these changes Aug 26, 2025
View reviewed changes

leofang enabled auto-merge (squash) August 26, 2025 17:57

leofang merged commit 6a83341 into 12.9.xAug 26, 2025
42 checks passed

leofang deleted the copilot/fix-13ebb0da-7044-4524-bd83-05314e7e7e53 branch August 26, 2025 18:19

leofang linked an issue Aug 26, 2025 that may be closed by this pull request
CI: Fix pathfinder CI infrastructure #810
Open

leofang mentioned this pull request Aug 26, 2025
CI: Fix pathfinder CI infrastructure #810
Open

cpcloud mentioned this pull request Oct 8, 2025
backport ft fix #1111
Closed

Uh oh!

Conversation

CopilotAI commented Aug 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Key Features

Uh oh!

copy-pr-botBot commented Aug 25, 2025

Uh oh!

leofang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

leofang commented Aug 25, 2025

Uh oh!

CopilotAI commented Aug 25, 2025

Uh oh!

leofang commented Aug 25, 2025

Uh oh!

leofang commented Aug 25, 2025

Uh oh!

CopilotAI commented Aug 25, 2025

Uh oh!

leofang commented Aug 25, 2025

Uh oh!

leofang commented Aug 25, 2025

Uh oh!

CopilotAI commented Aug 25, 2025

Uh oh!

rwgk left a comment

Choose a reason for hiding this comment

Uh oh!

rwgkAug 26, 2025

Choose a reason for hiding this comment

Uh oh!

leofangAug 26, 2025

Choose a reason for hiding this comment

Uh oh!

leofangAug 26, 2025

Choose a reason for hiding this comment

Uh oh!

leofang commented Aug 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CopilotAI commented Aug 25, 2025•
edited
Loading

leofang left a comment •
edited
Loading