Skip to content

Fix #891: Use built-in types rather than typing aliases for type annotations - #937

Merged
leofang merged 3 commits into
NVIDIA:mainfrom
mdboom:issue891
Sep 2, 2025
Merged

Fix #891: Use built-in types rather than typing aliases for type annotations#937
leofang merged 3 commits into
NVIDIA:mainfrom
mdboom:issue891

Conversation

@mdboom

@mdboommdboom commented Sep 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

closes#891

This is a replacement for #892 (it was easier to rebase by hand than get Copilot to do it...)

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-botBot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@mdboom

mdboom commented Sep 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@mdboommdboom mentioned this pull request Sep 2, 2025
Closed
@mdboom

mdboom commented Sep 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@mdboom

mdboom commented Sep 2, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@leofang
leofang merged commit 294151a into NVIDIA:mainSep 2, 2025
49 checks passed
@leofangleofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module labels Sep 2, 2025
@github-actions

github-actionsBot commented Sep 2, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

leofang pushed a commit that referenced this pull request Sep 5, 2025
@mdboom
Backport#937to 12.9.x branch (#943)
cca1dbf
* Generated changes
* Non-generated changes
@cpcloudcpcloud mentioned this pull request Oct 8, 2025
Closed
@mdboom
mdboom deleted the issue891 branch December 9, 2025 16:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 approved these changes

Assignees

@mdboommdboom

Labels

cuda.bindingsEverything related to the cuda.bindings moduleenhancementAny code-related improvementsP1Medium priority - Should do

Projects

None yet

Milestone

cuda-python 13.0.2 & 12.9.3

Development

Successfully merging this pull request may close these issues.

Use built-in types rather than typing aliases for type annotations where possible

3 participants

@mdboom@kkraus14@leofang