Skip to content

ci: move cibuildwheel config out of github actions workflows and into pyproject.tomls - #994

Merged
kkraus14 merged 2 commits into
NVIDIA:mainfrom
cpcloud:move-cibuildwheel-config-to-pyproject-toml
Sep 23, 2025
Merged

ci: move cibuildwheel config out of github actions workflows and into pyproject.tomls#994
kkraus14 merged 2 commits into
NVIDIA:mainfrom
cpcloud:move-cibuildwheel-config-to-pyproject-toml

Conversation

@cpcloud

@cpcloudcpcloud commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Moves cibuildwheel config out of github actions and into corresponding pyproject.toml files.

@copy-pr-bot

copy-pr-botBot commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

cpcloud
cpcloud commented Sep 19, 2025
View reviewed changes
Comment threadcuda_core/pyproject.toml
cpcloud
cpcloud commented Sep 19, 2025
View reviewed changes
Comment threadcuda_bindings/pyproject.toml
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

1 similar comment
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud
cpcloudforce-pushed the move-cibuildwheel-config-to-pyproject-toml branch from 4bb5410 to 261651bCompareSeptember 19, 2025 14:33
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

2 similar comments
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud
cpcloudforce-pushed the move-cibuildwheel-config-to-pyproject-toml branch from 1ad4b74 to c883a26CompareSeptember 19, 2025 16:52
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

2 similar comments
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud
cpcloudforce-pushed the move-cibuildwheel-config-to-pyproject-toml branch from c9c8dd2 to 3496530CompareSeptember 19, 2025 16:54
@cpcloud

cpcloud commented Sep 19, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@github-actions

This comment has been minimized.

Sign in to view
@cpcloud
cpcloudforce-pushed the move-cibuildwheel-config-to-pyproject-toml branch from f0dc073 to b748718CompareSeptember 22, 2025 14:28
@cpcloud

cpcloud commented Sep 22, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud
cpcloud requested a review from rwgkSeptember 22, 2025 15:21
rwgk
rwgk previously approved these changes Sep 22, 2025
View reviewed changes

@rwgkrwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but caveat: I'm more learning than reviewing when looking through this PR.

kkraus14
kkraus14 reviewed Sep 23, 2025
View reviewed changes
Comment threadci/tools/env-vars Outdated
@cpcloud
cpcloudforce-pushed the move-cibuildwheel-config-to-pyproject-toml branch from b748718 to cf7d2d8CompareSeptember 23, 2025 12:17
@cpcloud

cpcloud commented Sep 23, 2025

Copy link
Copy Markdown
ContributorAuthor

/ok to test

@cpcloud

cpcloud commented Sep 23, 2025

Copy link
Copy Markdown
ContributorAuthor

@kkraus14 Can you give this another review?

@kkraus14
kkraus14 merged commit 5fb83a1 into NVIDIA:mainSep 23, 2025
70 checks passed
@github-actions

github-actionsBot commented Sep 23, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

@cpcloud
cpcloud deleted the move-cibuildwheel-config-to-pyproject-toml branch September 23, 2025 16:32
@leofangleofang mentioned this pull request Sep 30, 2025
Merged
2 tasks
@leofang

leofang commented Oct 3, 2025

Copy link
Copy Markdown
Member

For posterity: a follow-up discussion happened here: https://github.com/NVIDIA/cuda-python/pull/1041/files#r2388712078

@leofangleofang added enhancement Any code-related improvements CI/CD CI/CD infrastructure labels Oct 3, 2025
@leofangleofang added this to the cuda.core beta 7 milestone Oct 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkraus14kkraus14kkraus14 approved these changes
@rwgkrwgkrwgk left review comments

Assignees

@cpcloudcpcloud

Labels

CI/CDCI/CD infrastructureenhancementAny code-related improvements

Projects

None yet

Milestone

cuda.core beta 7

Development

Successfully merging this pull request may close these issues.

4 participants

@cpcloud@leofang@rwgk@kkraus14