Skip to content

test skills - #1264

Closed
ramakrishnap-nv wants to merge 2 commits into
release/26.06from
test-skills
Closed

test skills#1264
ramakrishnap-nv wants to merge 2 commits into
release/26.06from
test-skills

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

test skills

Add SPDX-FileCopyrightText / SPDX-License-Identifier headers (Apache-2.0)
to markdown files in the cuopt-routing-api-python and routing-formulation
skills.
@copy-pr-bot

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review May 20, 2026 22:16
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerMay 20, 2026 22:16
@ramakrishnap-nvramakrishnap-nv self-assigned this May 20, 2026
@ramakrishnap-nvramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 20, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

@coderabbitai

coderabbitaiBot commented May 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds SPDX copyright/Apache-2.0 header blocks to multiple skill documentation files, updates small wording and reference links in two skill-card.md files, and replaces the DSSE payloads/signatures in two skill.oms.sig Sigstore bundles.

Changes

Documentation and skill-card edits

Layer / File(s)Summary
SPDX headers and skill-card edits
skills/cuopt-routing-api-python/SKILL.md, skills/cuopt-routing-api-python/assets/README.md, skills/cuopt-routing-api-python/assets/pdp_basic/README.md, skills/cuopt-routing-api-python/assets/vrp_basic/README.md, skills/cuopt-routing-api-python/resources/examples.md, skills/cuopt-routing-api-python/resources/server_examples.md, skills/cuopt-routing-api-python/skill-card.md, skills/routing-formulation/SKILL.md, skills/routing-formulation/skill-card.md
Inserted SPDX copyright and SPDX-License-Identifier: Apache-2.0 header blocks at the top of the listed Markdown files; updated two skill-card lines to rephrase wording and add reference links.

Sigstore bundle updates

Layer / File(s)Summary
Update DSSE payloads and signatures
skills/cuopt-routing-api-python/skill.oms.sig, skills/routing-formulation/skill.oms.sig
Replaced the DSSE envelope payload contents (predicate/resource digests and predicate fields) and signatures[0].sig; one bundle also had certificate rawBytes changed in verificationMaterial. No code or exported API changes.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • NVIDIA/cuopt#1249: Overlaps with prior updates to skill.oms.sig and skill-card.md metadata for the same skills.

Suggested reviewers

  • tmckayus
  • Iroy30
  • jameslamb
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check nameStatusExplanationResolution
Title check❓ InconclusiveThe title 'test skills' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the actual changes being made.Replace with a descriptive title reflecting the main changes, such as 'Add SPDX license headers and update skill documentation' or 'Add NVSkills validation signatures'.
Description check❓ InconclusiveThe description 'test skills' is extremely vague and generic, providing no meaningful information about what the changeset accomplishes.Provide a descriptive explanation of the changes, such as adding license headers, updating documentation, or attaching validation signatures.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test-skills

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
skills/routing-formulation/SKILL.md (1)

1-10: Ensure NVSkills CI validation before merge.

All changes in this PR modify files under the skills/ directory. As per coding guidelines, these changes must be validated by NVSkills CI before merge.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/routing-formulation/SKILL.md` around lines 1 - 10, This PR changes
files under skills; before merging ensure the NVSkills CI pipeline runs and
passes—update the PR checklist / CI configuration so NVSkills validation is
triggered for the skill named "routing-formulation" (version "26.06.00") and
confirm all NVSkills CI checks complete successfully; if NVSkills config is
missing or excludes the skills/ path, add or correct the CI trigger so changes
under skills/ invoke the NVSkills validation step.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@skills/routing-formulation/SKILL.md`:
- Around line 1-10: This PR changes files under skills; before merging ensure
the NVSkills CI pipeline runs and passes—update the PR checklist / CI
configuration so NVSkills validation is triggered for the skill named
"routing-formulation" (version "26.06.00") and confirm all NVSkills CI checks
complete successfully; if NVSkills config is missing or excludes the skills/
path, add or correct the CI trigger so changes under skills/ invoke the NVSkills
validation step.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eeb267ea-fe7b-4007-bc3b-6305d6ed27ee

📥 Commits

Reviewing files that changed from the base of the PR and between b2093e0 and c708cc3.

📒 Files selected for processing (9)
  • skills/cuopt-routing-api-python/SKILL.md
  • skills/cuopt-routing-api-python/assets/README.md
  • skills/cuopt-routing-api-python/assets/pdp_basic/README.md
  • skills/cuopt-routing-api-python/assets/vrp_basic/README.md
  • skills/cuopt-routing-api-python/resources/examples.md
  • skills/cuopt-routing-api-python/resources/server_examples.md
  • skills/cuopt-routing-api-python/skill-card.md
  • skills/routing-formulation/SKILL.md
  • skills/routing-formulation/skill-card.md

@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

1 similar comment
@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
skills/cuopt-routing-api-python/skill-card.md (1)

1-41: ⚠️ Potential issue | 🟠 Major

NVSkills CI not passing for skills/ PR—block merge until it runs successfully

  • PR #1264 shows “Request NVSkills CI” = SKIPPED and no NVSkills-related status check is present in statusCheckRollup; NVSkills CI validation isn’t complete for skills/cuopt-routing-api-python/skill-card.md.
  • Ensure NVSkills CI runs and passes before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-routing-api-python/skill-card.md` around lines 1 - 41, The
NVSkills CI did not run for this PR (Request NVSkills CI = SKIPPED), so trigger
and ensure the NVSkills validation completes and passes before merging; re-run
the pipeline for PR `#1264` (or rebase/commit to re-trigger checks), confirm the
NVSkills-related status check appears in the statusCheckRollup and shows a
successful/pass result, and only then proceed with merge of the skill-card.md
changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@skills/cuopt-routing-api-python/skill-card.md`:
- Around line 1-41: The NVSkills CI did not run for this PR (Request NVSkills CI
= SKIPPED), so trigger and ensure the NVSkills validation completes and passes
before merging; re-run the pipeline for PR `#1264` (or rebase/commit to re-trigger
checks), confirm the NVSkills-related status check appears in the
statusCheckRollup and shows a successful/pass result, and only then proceed with
merge of the skill-card.md changes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5ce9da49-08ad-4bb5-986a-baa8b9165254

📥 Commits

Reviewing files that changed from the base of the PR and between c708cc3 and 04de7eb.

📒 Files selected for processing (4)
  • skills/cuopt-routing-api-python/skill-card.md
  • skills/cuopt-routing-api-python/skill.oms.sig
  • skills/routing-formulation/skill-card.md
  • skills/routing-formulation/skill.oms.sig

@ramakrishnap-nv
ramakrishnap-nv deleted the test-skills branch July 9, 2026 18:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ramakrishnap-nv@svc-nvskills-signing