Skip to content

skills/cuopt-install:Add eval - #1324

Merged
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-install
May 28, 2026
Merged

skills/cuopt-install:Add eval#1324
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-install

Conversation

@ramakrishnap-nv

@ramakrishnap-nvramakrishnap-nv commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Add eval for cuopt-install

Adds an evals/evals.json for the cuopt-install skill so NV-BASE Tier 3
agent evaluation runs against it, and trims duplicated content in SKILL.md
flagged by NV-BASE context-deduplication.
Last CI run: PASS with overall lift +0.16 on best-performing agent.
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@copy-pr-bot

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review May 28, 2026 23:10
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerMay 28, 2026 23:10
@ramakrishnap-nvramakrishnap-nv self-assigned this May 28, 2026
@ramakrishnap-nvramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 28, 2026
@ramakrishnap-nvramakrishnap-nv changed the title skills/cuopt-install: Tier 3 eval + SKILL.md trimskills/cuopt-install:Add evalMay 28, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

@coderabbitai

Copy link
Copy Markdown

Actionable comments posted: 0

@coderabbitai

coderabbitaiBot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR consolidates C API verification instructions to a canonical reference, adds a Docker installation evaluation test, introduces a benchmark report, updates the skill card metadata, and replaces the skill sigstore bundle.

Changes

cuOpt Installation Skill Improvement

Layer / File(s)Summary
Documentation reference consolidation
skills/cuopt-install/SKILL.md
C API verification instructions now reference canonical header/library discovery commands in references/verification_examples.md instead of inline find examples.
Skill card formatting and evaluation section
skills/cuopt-install/skill-card.md
Reworked owner/use-case headings, added cuOpt Docker Hub and examples references, and inserted a new evaluation section (agents, tasks, metrics, results).
Benchmark report addition
skills/cuopt-install/BENCHMARK.md
Added NVSkills-Eval 3-Tier benchmark report with evaluation metadata, per-dimension results, tiered validation findings, and publication recommendation.
Docker installation evaluation test
skills/cuopt-install/evals/evals.json
New evaluation spec containing inst-eval-001-docker-server that requires the official nvidia/cuopt CUDA 12 image and docker run flags --gpus all and -p 8000:8000.
Signature bundle update
skills/cuopt-install/skill.oms.sig
Replaced the DSSE/in-toto predicate payload and signatures to reflect updated resource digests and signed content.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • NVIDIA/cuopt#1301: Repo-wide resources/references/ rename touching related verification reference links.
  • NVIDIA/cuopt#1287: Related edits to cuopt-install artifacts and the skill signature bundle.

Suggested reviewers

  • Iroy30
  • tmckayus
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title directly refers to adding an evaluation for cuopt-install, which is the primary change across multiple files in this PR.
Description check✅ PassedThe description 'Add eval for cuopt-install' is related to the changeset, which adds evaluation files and updates documentation for the cuopt-install skill.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skills-cuopt-install

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/ok to test 936ebfb

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-install/skill-card.md`:
- Around line 61-68: The markdown block under the heading "## Evaluation
Results:" is missing surrounding blank lines (MD058); edit the content in
skill-card.md to add one blank line before the table start (the line with "|
Dimension | Num | `claude-code` | `codex` |") and one blank line after the table
end (the final "| Efficiency | 2 | 93% (-0%) | 78% (+51%) |" row) so the table
is separated from surrounding text and satisfies the linter.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 26c1922d-6b9d-4226-aae6-66bd864f3a60

📥 Commits

Reviewing files that changed from the base of the PR and between 235718d and 936ebfb.

📒 Files selected for processing (3)
  • skills/cuopt-install/BENCHMARK.md
  • skills/cuopt-install/skill-card.md
  • skills/cuopt-install/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
  • skills/cuopt-install/BENCHMARK.md

Comment on lines +61 to +68
## Evaluation Results: <br>
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 92% (+17%) |
| Discoverability | 2 | 100% (+0%) | 80% (+55%) |
| Effectiveness | 2 | 100% (+6%) | 100% (+2%) |
| Efficiency | 2 | 93% (-0%) | 78% (+51%) |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add blank lines around the evaluation results table to satisfy markdown lint.

The table block is missing surrounding blank lines (MD058), which can break strict markdown CI/linting.

Proposed fix
 ## Evaluation Results: <br>
+
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 92% (+17%) |
| Discoverability | 2 | 100% (+0%) | 80% (+55%) |
| Effectiveness | 2 | 100% (+6%) | 100% (+2%) |
| Efficiency | 2 | 93% (-0%) | 78% (+51%) |
+
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Evaluation Results: <br>
| Dimension | Num |`claude-code`|`codex`|
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 92% (+17%) |
| Discoverability | 2 | 100% (+0%) | 80% (+55%) |
| Effectiveness | 2 | 100% (+6%) | 100% (+2%) |
| Efficiency | 2 | 93% (-0%) | 78% (+51%) |
## Evaluation Results: <br>
| Dimension | Num |`claude-code`|`codex`|
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 92% (+17%) |
| Discoverability | 2 | 100% (+0%) | 80% (+55%) |
| Effectiveness | 2 | 100% (+6%) | 100% (+2%) |
| Efficiency | 2 | 93% (-0%) | 78% (+51%) |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 62-62: Tables should be surrounded by blank lines

(MD058, blanks-around-tables)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-install/skill-card.md` around lines 61 - 68, The markdown block
under the heading "## Evaluation Results:" is missing surrounding blank lines
(MD058); edit the content in skill-card.md to add one blank line before the
table start (the line with "| Dimension | Num | `claude-code` | `codex` |") and
one blank line after the table end (the final "| Efficiency | 2 | 93% (-0%) |
78% (+51%) |" row) so the table is separated from surrounding text and satisfies
the linter.

@ramakrishnap-nv
ramakrishnap-nv merged commit b597e56 into mainMay 28, 2026
23 checks passed
@coderabbitaicoderabbitaiBot mentioned this pull request May 29, 2026
2 tasks
@ramakrishnap-nvramakrishnap-nv mentioned this pull request Jul 8, 2026
3 tasks
@ramakrishnap-nv
ramakrishnap-nv deleted the skills-cuopt-install branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ramakrishnap-nv@tmckayus@svc-nvskills-signing