Skip to content

skills/cuopt-numerical-optimization-api-cli: update with benchmark details - #1331

Merged
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-numerical-optimization-api-cli
May 29, 2026
Merged

skills/cuopt-numerical-optimization-api-cli: update with benchmark details#1331
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-numerical-optimization-api-cli

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

update with benchmark details

@copy-pr-bot

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

…tails
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nvforce-pushed the skills-cuopt-numerical-optimization-api-cli branch from 12b9baa to 816f6eaCompareMay 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review May 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerMay 29, 2026 01:17
@coderabbitai

coderabbitaiBot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds an NVSkills evaluation report, updates the skill card metadata and SKILL.md spacing, and replaces the skill’s sigstore DSSE bundle to reflect updated payload digests and signatures.

Changes

Skill packaging and docs

Layer / File(s)Summary
Markdown spacing adjustment
skills/cuopt-numerical-optimization-api-cli/SKILL.md
Blank line inserted after YAML front matter and before the main markdown header.
Add evaluation BENCHMARK.md
skills/cuopt-numerical-optimization-api-cli/BENCHMARK.md
New NVSkills-Eval report with metadata, agents, dimension definitions, Tier 1 findings, Tier 2 deduplication, and a publication recommendation.
Update skill-card metadata and evaluation sections
skills/cuopt-numerical-optimization-api-cli/skill-card.md
Reformat owner/license headings, concentrate use-case text, expand references and skill output, and add evaluation configuration/results.
Replace sigstore DSSE bundle
skills/cuopt-numerical-optimization-api-cli/skill.oms.sig
Updated DSSE payload (subject/resource digests) and signatures to match revised artifacts.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • NVIDIA/cuopt#1287: Related NVSkills validation and SKILL.md metadata updates for the cuOpt CLI skill.
  • NVIDIA/cuopt#1308: Related sigstore/attestation updates and evals smoke-test entry for the skill.

Suggested reviewers

  • Iroy30
  • tmckayus

Suggested labels

non-breaking, improvement

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding benchmark details to the cuopt skill files, as evidenced by the BENCHMARK.md addition and skill-card.md updates.
Description check✅ PassedThe description 'update with benchmark details' directly relates to the changeset, which adds a comprehensive BENCHMARK.md file and updates skill documentation with evaluation results.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skills-cuopt-numerical-optimization-api-cli

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramakrishnap-nvramakrishnap-nv self-assigned this May 29, 2026
@ramakrishnap-nvramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 29, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-numerical-optimization-api-cli/skill-card.md`:
- Around line 61-63: The markdown heading "## Evaluation Results:" is followed
immediately by a table, triggering MD058; insert a single blank line between the
"## Evaluation Results:" heading and the start of the table (the line beginning
with "| Dimension |") in skill-card.md so there is one empty line separating
them, then run pre-commit checks (pre-commit run --all-files
--show-diff-on-failure) to verify the lint warning is resolved.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1187e410-15e4-4ea8-a5e1-2ad128d1bdcc

📥 Commits

Reviewing files that changed from the base of the PR and between 816f6ea and cfda568.

📒 Files selected for processing (3)
  • skills/cuopt-numerical-optimization-api-cli/BENCHMARK.md
  • skills/cuopt-numerical-optimization-api-cli/skill-card.md
  • skills/cuopt-numerical-optimization-api-cli/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
  • skills/cuopt-numerical-optimization-api-cli/BENCHMARK.md

Comment on lines +61 to +63
## Evaluation Results: <br>
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a blank line before the evaluation results table.

The table starts immediately after the heading, which triggers MD058 (blanks-around-tables). Please insert one blank line between the heading and the table.

🛠️ Suggested fix
 ## Evaluation Results: <br>
+
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|

As per coding guidelines, "Use pre-commit run --all-files --show-diff-on-failure to check code formatting and linting on all files before committing".

📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Evaluation Results: <br>
| Dimension | Num |`claude-code`|`codex`|
|---|---:|---:|---:|
## Evaluation Results: <br>
| Dimension | Num |`claude-code`|`codex`|
|---|---:|---:|---:|
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 62-62: Tables should be surrounded by blank lines

(MD058, blanks-around-tables)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-api-cli/skill-card.md` around lines 61 -
63, The markdown heading "## Evaluation Results:" is followed immediately by a
table, triggering MD058; insert a single blank line between the "## Evaluation
Results:" heading and the start of the table (the line beginning with "|
Dimension |") in skill-card.md so there is one empty line separating them, then
run pre-commit checks (pre-commit run --all-files --show-diff-on-failure) to
verify the lint warning is resolved.

@ramakrishnap-nv
ramakrishnap-nv merged commit b1703b2 into mainMay 29, 2026
4 checks passed
@ramakrishnap-nvramakrishnap-nv mentioned this pull request Jul 8, 2026
3 tasks
@ramakrishnap-nv
ramakrishnap-nv deleted the skills-cuopt-numerical-optimization-api-cli branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ramakrishnap-nv@svc-nvskills-signing