Skip to content

skills/cuopt-server-api-python: update with benchmark details - #1334

Merged
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-server-api-python
May 29, 2026
Merged

skills/cuopt-server-api-python: update with benchmark details#1334
ramakrishnap-nv merged 2 commits into
mainfrom
skills-cuopt-server-api-python

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

update with benchmark details

@copy-pr-bot

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nvforce-pushed the skills-cuopt-server-api-python branch from e0bb81e to 4839c0eCompareMay 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review May 29, 2026 01:17
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerMay 29, 2026 01:17
@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

@coderabbitai

coderabbitaiBot commented May 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Updates the cuopt-server-api-python skill: inserts a formatting line in SKILL.md, adds a generated BENCHMARK.md report, expands skill-card metadata and evaluation details, and replaces the Sigstore DSSE bundle with updated digests and signature.

Changes

Skill documentation and signing

Layer / File(s)Summary
SKILL spacing adjustment
skills/cuopt-server-api-python/SKILL.md
Inserted an empty line at line 17 to adjust spacing between the front-matter and subsequent content.
Benchmark report
skills/cuopt-server-api-python/BENCHMARK.md
Adds a generated NVSkills-Eval BENCHMARK.md containing evaluation metadata, agents, checks, findings, and a publication recommendation.
Skill-card metadata & evaluation
skills/cuopt-server-api-python/skill-card.md
Reformatted Owner/License/Use Case, added references and output-format clarification, and substantially expanded Evaluation (agents, tasks, metrics, signals, and results table).
Sigstore DSSE bundle replacement
skills/cuopt-server-api-python/skill.oms.sig
Replaced the Sigstore DSSE bundle with a new DSSE payload updating statement digests and the DSSE signature; serialization predicate ignore_paths adjusted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • NVIDIA/cuopt#1287: Related skill metadata, signing, and CI/signing artifact updates for the same skills.

Suggested reviewers

  • Iroy30
  • tmckayus
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly summarizes the main change: updating the cuopt-server-api-python skill with benchmark details, which aligns with the addition of BENCHMARK.md and expansion of evaluation content in other files.
Description check✅ PassedThe description 'update with benchmark details' is directly related to the changeset, which includes a new benchmark report file (BENCHMARK.md) and expanded evaluation sections in skill-card.md.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skills-cuopt-server-api-python

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
skills/cuopt-server-api-python/SKILL.md (1)

15-17: 💤 Low value

Consider removing the extra blank line.

Three consecutive empty lines between the YAML front-matter and the heading may be excessive. Two blank lines (lines 15-16) typically provide sufficient spacing for documentation readability.

📝 Suggested formatting adjustment
 ---
-
# cuOpt Server — Deploy and client (Python/curl)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-server-api-python/SKILL.md` around lines 15 - 17, Remove one of
the extra blank lines between the YAML front-matter and the main heading in
SKILL.md so there are only two consecutive empty lines (i.e., collapse the three
blank lines down to two); locate the block immediately after the YAML
front-matter and before the top-level heading (the file's main heading) and
delete a single empty line to fix spacing.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-server-api-python/SKILL.md`:
- Line 17: The PR title promises "update with benchmark details" but SKILL.md
only contains an added empty line; either add the missing benchmark details to
SKILL.md (include the benchmark name, methodology, results, and any tables or
links) or change the PR title/description to accurately reflect the actual
change; locate and edit SKILL.md to either paste the intended benchmark section
or update the PR metadata so the title matches the committed content.
---
Nitpick comments:
In `@skills/cuopt-server-api-python/SKILL.md`:
- Around line 15-17: Remove one of the extra blank lines between the YAML
front-matter and the main heading in SKILL.md so there are only two consecutive
empty lines (i.e., collapse the three blank lines down to two); locate the block
immediately after the YAML front-matter and before the top-level heading (the
file's main heading) and delete a single empty line to fix spacing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d3d93b19-b698-4c37-be0b-4487086bdfc3

📥 Commits

Reviewing files that changed from the base of the PR and between 6c61fcb and 4839c0e.

📒 Files selected for processing (1)
  • skills/cuopt-server-api-python/SKILL.md

---



Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Critical: PR title claims "update with benchmark details" but no benchmark details are present.

The PR title states "update with benchmark details," yet the only change in this file is adding a single empty line. This is a significant discrepancy that suggests either:

  1. The intended benchmark details were not committed
  2. Wrong files were included in this PR
  3. The PR description is incorrect

Please verify that this changeset is complete and matches the intended changes described in the PR title.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-server-api-python/SKILL.md` at line 17, The PR title promises
"update with benchmark details" but SKILL.md only contains an added empty line;
either add the missing benchmark details to SKILL.md (include the benchmark
name, methodology, results, and any tables or links) or change the PR
title/description to accurately reflect the actual change; locate and edit
SKILL.md to either paste the intended benchmark section or update the PR
metadata so the title matches the committed content.

@ramakrishnap-nvramakrishnap-nv self-assigned this May 29, 2026
@ramakrishnap-nvramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels May 29, 2026
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-server-api-python/skill-card.md`:
- Around line 62-70: The markdown table under the "## Evaluation Results:"
heading in skill-card.md is missing blank lines around the table (MD058); open
the block containing the header "## Evaluation Results:" and the table starting
with the pipe row "| Dimension | Num | `claude-code` | `codex` |", then insert a
blank line immediately before the table and another blank line immediately after
the closing table row to separate the table from surrounding content; run
pre-commit (pre-commit run --all-files --show-diff-on-failure) to validate the
change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 281fcd25-7cb0-4fd8-97e3-2a20fc4a0f5b

📥 Commits

Reviewing files that changed from the base of the PR and between 4839c0e and e29a995.

📒 Files selected for processing (3)
  • skills/cuopt-server-api-python/BENCHMARK.md
  • skills/cuopt-server-api-python/skill-card.md
  • skills/cuopt-server-api-python/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
  • skills/cuopt-server-api-python/BENCHMARK.md

Comment on lines +62 to +70
## Evaluation Results: <br>
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 97% (+0%) |
| Discoverability | 2 | 100% (+0%) | 72% (+0%) |
| Effectiveness | 2 | 100% (+0%) | 100% (+0%) |
| Efficiency | 2 | 93% (-0%) | 56% (-1%) |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add blank lines around the evaluation table.

Line 63 starts a table without a preceding blank line, and the table block should also be separated from surrounding content to satisfy markdownlint (MD058).

Proposed fix
 ## Evaluation Results: <br>
+
| Dimension | Num | `claude-code` | `codex` |
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 97% (+0%) |
| Discoverability | 2 | 100% (+0%) | 72% (+0%) |
| Effectiveness | 2 | 100% (+0%) | 100% (+0%) |
| Efficiency | 2 | 93% (-0%) | 56% (-1%) |
+
## Skill Version(s): <br>
As per coding guidelines, "Use `pre-commit run --all-files --show-diff-on-failure` to check code formatting and linting on all files before committing."
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Evaluation Results: <br>
| Dimension | Num |`claude-code`|`codex`|
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 97% (+0%) |
| Discoverability | 2 | 100% (+0%) | 72% (+0%) |
| Effectiveness | 2 | 100% (+0%) | 100% (+0%) |
| Efficiency | 2 | 93% (-0%) | 56% (-1%) |
## Evaluation Results: <br>
| Dimension | Num |`claude-code`|`codex`|
|---|---:|---:|---:|
| Security | 2 | 100% (+0%) | 100% (+0%) |
| Correctness | 2 | 100% (+0%) | 97% (+0%) |
| Discoverability | 2 | 100% (+0%) | 72% (+0%) |
| Effectiveness | 2 | 100% (+0%) | 100% (+0%) |
| Efficiency | 2 | 93% (-0%) | 56% (-1%) |
## Skill Version(s): <br>
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)

[warning] 63-63: Tables should be surrounded by blank lines

(MD058, blanks-around-tables)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-server-api-python/skill-card.md` around lines 62 - 70, The
markdown table under the "## Evaluation Results:" heading in skill-card.md is
missing blank lines around the table (MD058); open the block containing the
header "## Evaluation Results:" and the table starting with the pipe row "|
Dimension | Num | `claude-code` | `codex` |", then insert a blank line
immediately before the table and another blank line immediately after the
closing table row to separate the table from surrounding content; run pre-commit
(pre-commit run --all-files --show-diff-on-failure) to validate the change.

@ramakrishnap-nv
ramakrishnap-nv merged commit dc73235 into mainMay 29, 2026
4 checks passed
@ramakrishnap-nv
ramakrishnap-nv deleted the skills-cuopt-server-api-python branch July 9, 2026 18:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ramakrishnap-nv@svc-nvskills-signing