Skip to content

skills(multi-objective): add blank line after frontmatter to enable skill signing - #1433

Merged
ramakrishnap-nv merged 2 commits into
mainfrom
skill/sign-multi-objective
Jun 13, 2026
Merged

skills(multi-objective): add blank line after frontmatter to enable skill signing#1433
ramakrishnap-nv merged 2 commits into
mainfrom
skill/sign-multi-objective

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a blank line after the frontmatter closing --- in skills/cuopt-multi-objective-exploration/SKILL.md to enable skill signing.

Test plan

  • Verify skill signing pipeline picks up the updated file

🤖 Generated with Claude Code

…kill signing
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerJune 12, 2026 20:53
@coderabbitai

coderabbitaiBot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates skill documentation and the skill-card and benchmark reports (content, evaluation metadata, and result tables), and replaces the skill.oms.sig DSSE signature bundle; it also inserts one blank line in SKILL.md.

Changes

CuOpt Multi-Objective Skill updates

Layer / File(s)Summary
SKILL whitespace
skills/cuopt-multi-objective-exploration/SKILL.md
Inserted one blank line near the start of the "Multi-Objective Exploration" section.
Skill card edits
skills/cuopt-multi-objective-exploration/skill-card.md
Reworded the Use Case, updated the "cuOpt Examples" reference, clarified evaluation agents/tasks (Claude Code, Codex; NVSkills-Eval run, 4 tasks), and refreshed the evaluation results table (Num counts changed 6→4).
Benchmark updates
skills/cuopt-multi-objective-exploration/BENCHMARK.md
Updated evaluation metadata (date, dataset size 3→4, attempts per task), adjusted dataset composition (positive tasks 2→3), refreshed results table percentages/uplifts, and modified Tier 1/Tier 2 validation summaries.
Signature bundle
skills/cuopt-multi-objective-exploration/skill.oms.sig
Replaced the DSSE envelope payload digests and signature blob while retaining bundle structure and certificate chain.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • tmckayus
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly describes the main change: adding a blank line to SKILL.md to enable skill signing, which aligns with the primary content modification.
Description check✅ PassedThe description directly relates to the changeset, explaining the blank line addition and its purpose for skill signing, matching the actual modifications across the files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skill/sign-multi-objective

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/nvskills-ci

@ramakrishnap-nvramakrishnap-nv self-assigned this Jun 12, 2026
@ramakrishnap-nvramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jun 12, 2026
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-multi-objective-exploration/skill-card.md`:
- Around line 32-34: The "Evaluation Agents Used" entries use only code names
(`claude-code`, `codex`) instead of the required human-readable format; update
the list under the "Evaluation Agents Used" heading to follow the template
pattern by prepending human-readable names and keeping the code names in
parentheses (e.g., "Claude Code (`claude-code`)", "Codex (`codex`)") so the
entries for claude-code and codex match the common skill-card contract and
NVSkills validation expectations.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2aed5447-c04b-4101-844f-fba360d4a108

📥 Commits

Reviewing files that changed from the base of the PR and between 255c7e2 and 69be7d8.

📒 Files selected for processing (3)
  • skills/cuopt-multi-objective-exploration/BENCHMARK.md
  • skills/cuopt-multi-objective-exploration/skill-card.md
  • skills/cuopt-multi-objective-exploration/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
  • skills/cuopt-multi-objective-exploration/BENCHMARK.md

Comment on lines 32 to +34
## Evaluation Agents Used: <br>
- Claude Code (`claude-code`) <br>
- Codex (`codex`) <br>
- claude-code <br>
- codex <br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Evaluation Agents format deviates from the documented template pattern.

Lines 32-34 list agent names as code-only (claude-code, codex), but the common skill-card template (referenced in context) specifies the format as Human-Readable Name (code-name), e.g., - Claude Code (claude-code). The current version is missing the human-readable agent names.

Verify whether this format change is intentional or should be corrected to match the template contract for consistency with other skills and NVSkills validation expectations.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-multi-objective-exploration/skill-card.md` around lines 32 - 34,
The "Evaluation Agents Used" entries use only code names (`claude-code`,
`codex`) instead of the required human-readable format; update the list under
the "Evaluation Agents Used" heading to follow the template pattern by
prepending human-readable names and keeping the code names in parentheses (e.g.,
"Claude Code (`claude-code`)", "Codex (`codex`)") so the entries for claude-code
and codex match the common skill-card contract and NVSkills validation
expectations.

@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/ok to test 69be7d8

@ramakrishnap-nv
ramakrishnap-nv merged commit 03fe3fc into mainJun 13, 2026
26 checks passed
@ramakrishnap-nvramakrishnap-nv added this to the 26.08 milestone Jul 8, 2026
@ramakrishnap-nv
ramakrishnap-nv deleted the skill/sign-multi-objective branch July 9, 2026 18:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ramakrishnap-nv@tmckayus@svc-nvskills-signing