Uh oh!
There was an error while loading. Please reload this page.
ci: trigger numerical optimization skill evals - #1453
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ramakrishnap-nv
commented
Jun 23, 2026
/nvskills-ci |
📝 WalkthroughWalkthroughThe cuopt-numerical-optimization-formulation skill documentation was updated to reflect a new evaluation run. The Use Case description was rewritten to emphasize parsing unstructured problems into LP/MILP/QP formulations. Skill Output types were expanded to include Code output with detailed Markdown mathematical formulations. Evaluation methodology was clarified with updated Agents and Tasks references. Benchmark results were updated from evaluation date 2026-06-22 to 2026-06-23 with revised scores for Correctness, Discoverability, Effectiveness, and Efficiency. Testing status was expanded with Agent Red-Teaming and marked security items as not completed. The Sigstore signature bundle was updated to reflect content changes. A blank line was added to SKILL.md for formatting. ChangesSkill Evaluation Documentation Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-numerical-optimization-formulation/skill-card.md`:
- Line 67: The Efficiency row contains a confusing delta value of (-0%) for the
third column which should be normalized to (0%) for consistency and clarity in
the benchmark table. Locate the Efficiency row that shows 72% (+45%) and update
the corresponding delta value from (-0%) to (0%) to maintain uniform formatting
across all delta values.
- Line 39: The discoverability claim on Line 45 states the skill should avoid
being used when irrelevant, but Line 39 only documents evaluation against
positive skill-activation cases. To fix this methodological gap, either add
negative test cases to the evaluation and update Line 39 to reflect the expanded
test set, or narrow the discoverability description on Line 45 to only claim
measurable behavior from positive-only testing (such as only claiming successful
activation in relevant contexts, without claiming avoidance of irrelevant use
cases).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0fb56caa-3319-4997-968c-aba5f1d07504
📒 Files selected for processing (3)
skills/cuopt-numerical-optimization-formulation/BENCHMARK.mdskills/cuopt-numerical-optimization-formulation/skill-card.mdskills/cuopt-numerical-optimization-formulation/skill.oms.sig
✅ Files skipped from review due to trivial changes (1)
- skills/cuopt-numerical-optimization-formulation/BENCHMARK.md
| ## Evaluation Tasks: <br> | ||
| Evaluated against 3 internal skill-activation tasks (NVSkills-Eval, external profile, astra-sandbox environment). <br> | ||
| Evaluated against 3 internal evaluation tasks (all positive skill-activation cases) via NVSkills-Eval external profile. <br> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Discoverability is over-claimed with positive-only tasks.
Line 39 says all 3 evaluation tasks are positive activation cases, but discoverability (Line 45) also includes “avoid using it when irrelevant.” That irrelevant-case behavior is not measurable from positive-only tasks, so the discoverability result is methodologically incomplete.
Suggested doc fix
-Evaluated against 3 internal evaluation tasks (all positive skill-activation cases) via NVSkills-Eval external profile. <br>+Evaluated against 3 internal evaluation tasks (all positive skill-activation cases) via NVSkills-Eval external profile. In this run, Discoverability reflects relevant-case activation only (no negative-control tasks). <br>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Evaluated against 3 internal evaluation tasks (all positive skill-activation cases) via NVSkills-Eval external profile. <br> | |
| Evaluated against 3 internal evaluation tasks (all positive skill-activation cases) via NVSkills-Eval external profile. In this run, Discoverability reflects relevant-case activation only (no negative-control tasks). <br> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-formulation/skill-card.md` at line 39,
The discoverability claim on Line 45 states the skill should avoid being used
when irrelevant, but Line 39 only documents evaluation against positive
skill-activation cases. To fix this methodological gap, either add negative test
cases to the evaluation and update Line 39 to reflect the expanded test set, or
narrow the discoverability description on Line 45 to only claim measurable
behavior from positive-only testing (such as only claiming successful activation
in relevant contexts, without claiming avoidance of irrelevant use cases).
| | Correctness | 3 | 83% (+33%) | 33% (-7%) | | ||
| | Discoverability | 3 | 67% (+67%) | 0% (+0%) | | ||
| | Effectiveness | 3 | 98% (+5%) | 67% (-11%) | | ||
| | Efficiency | 3 | 72% (+45%) | 28% (-0%) | |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Normalize delta formatting to avoid -0%.
Line 67 shows 28% (-0%), which is confusing in a published benchmark table. Use 0% for zero deltas.
Suggested doc fix
-| Efficiency | 3 | 72% (+45%) | 28% (-0%) |+| Efficiency | 3 | 72% (+45%) | 28% (0%) |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-numerical-optimization-formulation/skill-card.md` at line 67,
The Efficiency row contains a confusing delta value of (-0%) for the third
column which should be normalized to (0%) for consistency and clarity in the
benchmark table. Locate the Efficiency row that shows 72% (+45%) and update the
corresponding delta value from (-0%) to (0%) to maintain uniform formatting
across all delta values.
Trivial whitespace change to trigger CI evals for the numerical optimization formulation skill.