Skip to content

Fixing FJ bugs, Termination status and MIP GAP parameters - #6

Merged
ramakrishnap-nv merged 2 commits into
NVIDIA:branch-25.05from
ramakrishnap-nv:update_push_5_9_2025
May 10, 2025
Merged

Fixing FJ bugs, Termination status and MIP GAP parameters#6
ramakrishnap-nv merged 2 commits into
NVIDIA:branch-25.05from
ramakrishnap-nv:update_push_5_9_2025

Conversation

@ramakrishnap-nv

@ramakrishnap-nvramakrishnap-nv commented May 9, 2025

Copy link
Copy Markdown
Collaborator
 Recently Solution.termination_status was changed to an enum so that we can translate between strings and ints for termination status. When the value is set, it needs to be cast into the correct enum so that we can return the name later in Solution.get_termination_reason().
Authors:
- Trevor McKay (https://github.com/tmckayus)
Approvers:
- Rajesh Gandham (https://github.com/rg20)
This PR fixes FJ bugs (feasible solution turned infeasible, objective/violation exploding to infinity, tolerance issues, LHS numerical issues), adds some quality improvements, FJ regression tests, and the ability to save problem_t instances to a MPS file for later debugging.
Authors:
- Alice Boucher (https://github.com/aliceb-nv)
Approvers:
- Akif ÇÖRDÜK (https://github.com/akifcorduk)
- Trevor McKay (https://github.com/tmckayus)
 Hook up MIP Gap parameters and add info about number of nodes explored and simplex iterations, other fixes (#2463)
Hooks up the MIP gap absolute and relative parameters in branch and bound
Returns info about the number of nodes explored and simplex iterations performed.
This PR also:
* Switches LP from returning solve time in seconds rather than milliseconds
* Fixes an issue on degme where dual simplex not stopping when PDLP was already finished.
* Remove mention of LPs in standard form. Since we don't require the LP to be in standard form.
FJ bug fixes, tests and improvements (#2458)
This PR fixes FJ bugs (feasible solution turned infeasible, objective/violation exploding to infinity, tolerance issues, LHS numerical issues), adds some quality improvements, FJ regression tests, and the ability to save problem_t instances to a MPS file for later debugg
ing.
Authors:
- Alice Boucher (https://github.com/aliceb-nv)
Approvers:
- Akif ÇÖRDÜK (https://github.com/akifcorduk)
- Trevor McKay (https://github.com/tmckayus)

@ramakrishnap-nvramakrishnap-nv self-assigned this May 9, 2025
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerMay 9, 2025 20:02
@ramakrishnap-nvramakrishnap-nv added the non-breaking Introduces a non-breaking change label May 9, 2025
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code ownerMay 9, 2025 20:02
@ramakrishnap-nvramakrishnap-nv added the improvement Improves an existing functionality label May 9, 2025
rg20
rg20 approved these changes May 9, 2025

@rg20rg20 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramakrishnap-nv

Copy link
Copy Markdown
CollaboratorAuthor

/merge

@ramakrishnap-nv
ramakrishnap-nv merged commit eee1a91 into NVIDIA:branch-25.05May 10, 2025
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
ramakrishnap-nv added a commit that referenced this pull request Apr 22, 2026
- Escape </script> in dashboard embedded JSON to prevent XSS (#4 critical)
- Make Slack curl non-fatal with timeout + fallback so nightly pipeline
isn't killed by transient Slack failures (#10)
- Don't overwrite partial JUnit XML when test collection fails after
crash — write crash marker to a separate file (#6)
- Make flaky validation test markers PID-scoped to prevent cross-run
contamination (#12)
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ramakrishnap-nv@tmckayus@rg20