Uh oh!
There was an error while loading. Please reload this page.
Fix dilated Conv2d/Conv3d output size calculation - #3526
Open
wei-core wants to merge 1 commit into
Open
Conversation
Compute each output extent from the effective dilated filter size, (filter - 1) * dilation + 1, in the Conv2d and Conv3d problem-size constructors. Add host-only regression coverage for 2D and 3D constructors, including asymmetric padding and unit filters. Signed-off-by: WikAlie <194917782+wei-core@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(filter - 1) * dilation + 1Background
The existing formula subtracts
filter * dilation. It agrees with the standard convolution output-size formula only when dilation is 1. For dilation greater than 1 it undersizes the output, and a 1x1 filter is incorrectly made smaller by increasing dilation.Contribution roles
I led the contribution direction and acceptance criteria, reviewed and approved
the final design, and reviewed every changed line. I understand the change and
own the final design decision and the submission. AI assistance was used for
repository research, root-cause analysis, implementation preparation, and
automated validation execution.
Testing
3x4instead of4x6, and 3D output4x3x4instead of5x4x6test/unit/conv/problem_size.cppwith MSVC 19.44, CUDA 12.9 headers, CCCL headers, and GoogleTest v1.14.0Fixes#3502