Uh oh!
There was an error while loading. Please reload this page.
Fix validation gaps (Resolves #3542) - #3547
Open
DRJ-YDV wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#3542.
This PR addresses the four validation gaps outlined in the issue:
Grouped GEMM Validation (
gemm_grouped.h):Added a check in
can_implementto returnkErrorInvalidProblemifhost_problem_sizesis null andkRequiresPrecomputationis true. This prevents host segfaults duringprecompute.Split-K Parallel Zero Division (
gemm_splitk_parallel.h):Added a check in
can_implementto properly returnkErrorInvalidProblemifsplit_k_slices == 0, preventing a divide-by-zero fault.Batch Grid Dimension Wrapping (
threadblock_swizzle.h):Clamped the batched grid
zdimension to65535instead of wrapping it via modulo. This stops multiples of 65536 from producing a 0-dimension launch.Sm80 EVT assert-only validation (
gemm_universal_with_visitor.h):Replaced the debug-only
assert()statements with a propercan_implementvalidation pass that safely returnskErrorNotSupportedfor Split-K Parallel, Split-K Serial, and Array GEMM modes, preventing silent garbage execution in release builds.