Uh oh!
There was an error while loading. Please reload this page.
Correct host reference MRE padded diagonal fill and Gaussian seed - #3554
Open
Hashim1999164 wants to merge 1 commit into
Open
Correct host reference MRE padded diagonal fill and Gaussian seed#3554Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
TensorMRE now divides after the subtraction. Padded diagonal fill keeps each fill mode self contained and leaves a zero band on the diagonal. Gaussian sparsity uses one engine seeded with the caller seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #3543
TensorMRE now divides after the subtraction so mean relative error is the absolute difference of lhs and rhs over the absolute value of rhs plus epsilon. Padded diagonal fill keeps each fill mode self contained and leaves a zero band of width alignment on the diagonal. Gaussian sparsity uses one Bernoulli engine seeded with the caller seed instead of constructing a fresh random_device engine per element.