Uh oh!
There was an error while loading. Please reload this page.
[conv] Fix degenerate spatial extent calculation, grouped channel sizing, and add device wrapper validation tests - #3559
Open
Sadik00789 wants to merge 1 commit into
Open
Conversation
…ng, and update device wrappers
Sadik00789force-pushed
the
fix-conv-device-wrappers
branch
from
August 27, 2026 11:49
1070903 to
da9fd9fCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves stale geometry/pointer state across convolution device wrappers, adds missing 2 GiB overflow gates, clamps degenerate spatial extents, fixes 3D grouped convolution channel sizing, and adds unit test coverage:
update()in convolution device wrappers (direct_convolution.h,implicit_gemm_convolution.h,implicit_gemm_convolution_fusion.h) to properly refresh internal tensor geometry and fused-output pointers rather than retaining stale parameters.P,Q,Z) to0inconv2d_problem_size.handconv3d_problem_size.hwhen(Dim + pads - filter_span) < 0.can_implement()across SM90/SM100 collective and kernel layers.filter_c()andfilter_size()inconv3d_problem_size.hto divide channels bygroups(C / groups).<cute/tensor.hpp>inconvnd_problem_shape.hppso CuTe utilities (take,reverse,insert,for_each,make_seq) resolve across standalone translation units.test/unit/conv/device/conv_validation_and_update.cuto verify degenerate spatial extent clamping, 2 GiB gating, and runtime pointer/geometry updates.Files Changed
include/cutlass/conv/conv2d_problem_size.h: ClampedPandQspatial extents to 0 against negative numerators.include/cutlass/conv/conv3d_problem_size.h: ClampedZ,P,Qspatial extents and fixedfilter_c()/filter_size()channel sizing for grouped convolutions.include/cutlass/conv/convnd_problem_shape.hpp: Added#include "cute/tensor.hpp"for CuTe tuple algorithm definitions.include/cutlass/conv/device/direct_convolution.h: Updatedupdate()geometry refreshes and runtime parameter validation.include/cutlass/conv/device/implicit_gemm_convolution.h: Added 2 GiB overflow checks and fixed stale pointer caching onupdate().include/cutlass/conv/device/implicit_gemm_convolution_fusion.h: Fixed stale fused-output pointer updates and refreshed geometry state.include/cutlass/conv/collective/sm90_implicit_gemm_gmma_ss_warpspecialized.hpp: Added spatial extent validity checks incan_implement().include/cutlass/conv/kernel/sm100_implicit_gemm_tma_warpspecialized.hpp: Added problem shape validation in kernel execution entry points.test/unit/conv/device/CMakeLists.txt: Registeredcutlass_test_unit_conv_device_validationtest target.test/unit/conv/device/conv_validation_and_update.cu: Added test suite for degenerate extents, 2 GiB offset gating, and wrapperupdate()refreshes.Testing
Built and verified passing with GCC 13 and CUDA 12.6 targeting SM86: