Skip to content

fix(styles): native text-box support - #231

Open
coryrylan wants to merge 1 commit into
mainfrom
topic-text-box-css
Open

fix(styles): native text-box support#231
coryrylan wants to merge 1 commit into
mainfrom
topic-text-box-css

Conversation

@coryrylan

@coryrylancoryrylan commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator
  • use native css text-box support
  • remove legacy fallback for firefox

Summary by CodeRabbit

  • Bug Fixes

    • Improved typography styling by removing an outdated Firefox-specific fallback.
    • Reduced stylesheet size for faster loading.
  • Tests

    • Updated stylesheet size checks to reflect the smaller compressed output.

- use native css text-box support
- remove legacy fallback for firefox
Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coderabbitai

coderabbitaiBot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 6632b978-baef-4204-a5fb-2272bcd6786c

📥 Commits

Reviewing files that changed from the base of the PR and between 993cd55 and 29d9150.

📒 Files selected for processing (2)
  • projects/styles/src/index.test.lighthouse.ts
  • projects/styles/src/typography.css
💤 Files with no reviewable changes (1)
  • projects/styles/src/typography.css

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The PR removes the Firefox typography fallback block and lowers the compressed-size limits for typography.css and bundled index.css.

Changes

Typography CSS size reduction

Layer / File(s)Summary
Fallback removal and size budgets
projects/styles/src/typography.css, projects/styles/src/index.test.lighthouse.ts
The Firefox @supports fallback is removed. The Lighthouse limits change to 1.7 KB for typography.css and 3.1 KB for bundled index.css.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk:⚪ Minimal · up to 29d91

This is a localized stylesheet and bundle-size test update. No concrete current-head failure or correctness issue is supplied, so no actionable merge-blocking risk remains beyond normal validation.

Suggested reviewers:johnyanarella

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the main change: using native CSS text-box support in styles.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch topic-text-box-css

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

projects/styles/src/index.test.lighthouse.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@coryrylan@johnyanarella