Uh oh!
There was an error while loading. Please reload this page.
feat(node): add OOB node name support - #60
Conversation
Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughNode listing now supports node-name filtering and sorting. SDK models decode node names from basic and OOB responses. Basic and OOB tables and OOB descriptions display node names. OOB detection recognizes records with node names. ChangesNode name support
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:⚪ Minimal · up to Node names can now be filtered, sorted, decoded, and displayed for supported node views, with coverage for the SDK and CLI output paths. No concrete merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant NodeCommand
participant NodeSDK
participant FleetAPI
NodeCommand->>NodeSDK: pass trimmed node-name filter and sort
NodeSDK->>FleetAPI: send nodeName request parameters
FleetAPI-->>NodeSDK: return node names in node responses
NodeSDK-->>NodeCommand: provide decoded NodeName values
NodeCommand-->>NodeCommand: render node names in basic and OOB tables
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
Description
Checklist
git commit -s) per the Contributing Guidelines.Summary by CodeRabbit