Skip to content

feat(node): add OOB node name support - #60

Merged
jingxiang-z merged 1 commit into
mainfrom
feat/node-name-support
Sep 3, 2026
Merged

feat(node): add OOB node name support#60
jingxiang-z merged 1 commit into
mainfrom
feat/node-name-support

Conversation

@jingxiang-z

@jingxiang-zjingxiang-z commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Checklist

Summary by CodeRabbit

  • New Features
    • Added node-name filtering with support for partial matches.
    • Added sorting by node name and BMC hostname.
    • Node names now appear in basic and out-of-band node details and summaries.
    • Node listing and SDK responses now include node-name information.

Signed-off-by: Jingxiang Zhang <jingzhang@nvidia.com>
@coderabbitai

coderabbitaiBot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d5dd1c19-a503-4e04-8463-95bb0ebf2c63

📥 Commits

Reviewing files that changed from the base of the PR and between 37bad03 and 587107c.

📒 Files selected for processing (4)
  • internal/cmd/node/node.go
  • internal/cmd/node/node_test.go
  • nvfleetint/node.go
  • nvfleetint/node_test.go

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Node listing now supports node-name filtering and sorting. SDK models decode node names from basic and OOB responses. Basic and OOB tables and OOB descriptions display node names. OOB detection recognizes records with node names.

Changes

Node name support

Layer / File(s)Summary
SDK node-name contract and mapping
nvfleetint/node.go, nvfleetint/node_test.go
The SDK adds node-name fields, filtering, sorting, request mapping, response decoding, and validation coverage.
Node command filtering and sorting
internal/cmd/node/node.go, internal/cmd/node/node_test.go
The command adds the --node-name partial-match filter, trims its value, and accepts nodeName sorting.
Node output and OOB detection
internal/cmd/node/node.go, internal/cmd/node/node_test.go
Basic and OOB output include node names. OOB detection and description rows use node names.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to 58710

Node names can now be filtered, sorted, decoded, and displayed for supported node views, with coverage for the SDK and CLI output paths. No concrete merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
participant NodeCommand
participant NodeSDK
participant FleetAPI
NodeCommand->>NodeSDK: pass trimmed node-name filter and sort
NodeSDK->>FleetAPI: send nodeName request parameters
FleetAPI-->>NodeSDK: return node names in node responses
NodeSDK-->>NodeCommand: provide decoded NodeName values
NodeCommand-->>NodeCommand: render node names in basic and OOB tables
Loading

Suggested reviewers:emilyzhangbg

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedDocstring coverage is 82.61% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 23 functions across 4 files.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the primary change: adding OOB node name support. It is concise and specific.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/node-name-support

Comment @coderabbitai help to get the list of available commands.

@jingxiang-z
jingxiang-z merged commit cf4aab0 into mainSep 3, 2026
7 checks passed
@jingxiang-z
jingxiang-z deleted the feat/node-name-support branch September 3, 2026 17:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jingxiang-z@emilyzhangbg