Uh oh!
There was an error while loading. Please reload this page.
fix bwos queue bug - #1752
Conversation
ericniebler
commented
Jan 11, 2026
/ok to test f964a97 |
ericniebler
commented
Feb 25, 2026
@maikel could you take a look please? |
viktorika
commented
Mar 8, 2026
Please check this issue. I have described the problem in more detail.#1755 |
maikel
commented
Mar 28, 2026
@viktorika Does #1967 fix your issue? |
@maikel |
maikel
commented
Mar 30, 2026
That difference would need to be measured. I don't think that its a big issue, but intuition is often wrong here. More imprtantly is, that we have correct version first. Dropping tasks was a big nogo |
ericniebler
commented
Apr 27, 2026
what is the status of this pr? is a fix still needed here? attn: @viktorika@maikel |
maikel
commented
Apr 28, 2026
I believe my other changes a month ago have fixed this issue here |
1.Running TSAN on my M3 computer reports a data race. I believe there are some memory ordering issues with thief_block_, tail_, and steal_tail_.
2.There is an extremely small chance that elements within a certain block might be skipped and never executed. The reason is that the steal function uses steal_tail to determine whether it is complete or empty, but steal_tail == block_size might indicate that the current block has already been taken over.
std::uint64_t spos = steal_head_.load(stdexec::__std::memory_order_acquire);Using steal_head for checking can avoid this issue.