Skip to content

Add missing <vector> include in libdispatch_queue.hpp - #2160

Merged
ericniebler merged 1 commit into
NVIDIA:mainfrom
mikomikotaishi:fix/missing-vector-include
Aug 10, 2026
Merged

Add missing <vector> include in libdispatch_queue.hpp#2160
ericniebler merged 1 commit into
NVIDIA:mainfrom
mikomikotaishi:fix/missing-vector-include

Conversation

@mikomikotaishi

Copy link
Copy Markdown
Contributor

exec/libdispatch_queue.hpp uses std::vector (line 443 upstream, line 444 after my edits), but never includes <vector>. Although this typically arrives transitively through stdexec/execution.hpp, on libc++ 22, the include appears on C++23 but does not in C++26. stdexec/execution.hpp already includes the other std symbols used in this file transitively, but not std::vector.

#include<exec/libdispatch_queue.hpp>intmain() {
return0;
}

Result:

$ clang++ -std=c++2c -stdlib=libc++ -I include -fsyntax-only Test.cppexec/libdispatch_queue:443:12: error: no template named 'vector' in namespace 'std'

This, however, passes with -std=c++23.

This header only gets included on Apple platforms, and Linux/libstdc++ never compiles it. (I observed this on Homebrew LLVM clang 22.1.8 and bundled libc++, on macOS.)

The fix is simply adding #include <vector>.

@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mikomikotaishimikomikotaishi changed the title Add missing <vector> include in libdispatch_queue.hppAdd missing <vector> include in libdispatch_queue.hppAug 8, 2026
@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 858e4f1

@ericniebler
ericniebler merged commit 11f8016 into NVIDIA:mainAug 10, 2026
67 of 68 checks passed
@mikomikotaishi
mikomikotaishi deleted the fix/missing-vector-include branch August 10, 2026 03:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikomikotaishi@ericniebler