Skip to content

Preserve completion scheduler in timed fallbacks - #2164

Open
fallintoplace wants to merge 3 commits into
NVIDIA:mainfrom
fallintoplace:fix/timed-scheduler-completion-scheduler
Open

Preserve completion scheduler in timed fallbacks#2164
fallintoplace wants to merge 3 commits into
NVIDIA:mainfrom
fallintoplace:fix/timed-scheduler-completion-scheduler

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

The timed scheduler fallbacks currently use let_value(just(), ...) to keep now() lazy. let_value does not expose a completion scheduler, so both fallback senders lose get_completion_scheduler<set_value_t> even when the delegated timed sender advertises it.

This adds a small internal wrapper that forwards the fallback sender’s existing completion behavior and signatures and adds the set-value completion scheduler. Tests cover both fallback directions.

Testing

  • build/test/exec/test.exec
  • build/test/exec/test.exec "[timed_scheduler]"
  • build/test/exec/test.exec "[timed_thread_scheduler]"

@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment threadinclude/exec/timed_scheduler.hpp Outdated

#include <chrono>

namespace STDEXEC::__timed_scheduler_fallback

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in namespace experimental::execution instead of STDEXEC?

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 10db6f0

@fallintoplace
fallintoplace marked this pull request as ready for review August 9, 2026 13:23
@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 70dddb5

@ericniebler

Copy link
Copy Markdown
Collaborator

i'm ambivalent about merging this since it is a work-around for a problem in the let_ senders that #2077 aims to fix.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@fallintoplace@ericniebler