Skip to content

Fix inplace_stop_source request_stop return value - #2169

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/inplace-stop-source-request-stop-return
Open

Fix inplace_stop_source request_stop return value#2169
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/inplace-stop-source-request-stop-return

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

This fixes the boolean result returned by inplace_stop_source::request_stop().

The implementation currently returns true when a stop request was already made and false after this call successfully requests stop. That is reversed. The first call should return true, and later calls should return false.

The regression test checks both calls and confirms that the stop request is visible.

Tests:

  • cmake --build build --target test.exec -j 4
  • build/test/exec/test.exec '[stop_token]'
  • build/test/exec/test.exec

@copy-pr-bot

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@fallintoplace