Uh oh!
There was an error while loading. Please reload this page.
Fix inplace_stop_source request_stop return value - #2169
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the boolean result returned by
inplace_stop_source::request_stop().The implementation currently returns
truewhen a stop request was already made andfalseafter this call successfully requests stop. That is reversed. The first call should returntrue, and later calls should returnfalse.The regression test checks both calls and confirms that the stop request is visible.
Tests:
cmake --build build --target test.exec -j 4build/test/exec/test.exec '[stop_token]'build/test/exec/test.exec