Uh oh!
There was an error while loading. Please reload this page.
Fix fork_join exception fallback storage - #2170
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the exception fallback in
exec::fork_join.When caching a potentially throwing completion argument,
fork_joincurrently tries to emplace the exception result through_cache_._results_. The cache is already a__results_storage, so that member does not exist and the template branch fails to compile when instantiated.The fix emplaces the
set_error(std::exception_ptr)tuple directly into_cache_.The regression test uses a value with a potentially throwing copy constructor, returns it by reference from
just_from, and verifies thatsync_waitrethrows the copy failure.Tests:
cmake --build build --target test.exec -j 4build/test/exec/test.exec '[adaptors][fork_join]'build/test/exec/test.exec