Skip to content

Silent shelljs by default - #1220

Merged
rosen-vladimirov merged 1 commit into
releasefrom
vladimirov/update-shelljs-definitions
Nov 20, 2015
Merged

Silent shelljs by default#1220
rosen-vladimirov merged 1 commit into
releasefrom
vladimirov/update-shelljs-definitions

Conversation

@rosen-vladimirov

Copy link
Copy Markdown
Contributor

Shelljs likes to report some warnings, which we do not want to show to our users.
So set it to silent mode by default. In case for any shelljs command you want to show the warnings, just set silent to false before executing it.

This will also fix some warnings that are currently shown when preparing plugins. (cp - unable to find file...).

@rosen-vladimirovrosen-vladimirov self-assigned this Nov 19, 2015
@rosen-vladimirovrosen-vladimirov added this to the 1.5.0 milestone Nov 19, 2015
@ns-bot

Copy link
Copy Markdown

Test PASSed.

@rosen-vladimirov
rosen-vladimirovforce-pushed the vladimirov/update-shelljs-definitions branch from e640c9f to ebc905fCompareNovember 19, 2015 21:29
@ns-bot

Copy link
Copy Markdown

Test PASSed.

@teobugslayer

Copy link
Copy Markdown
Contributor

👍

Shelljs likes to report some warnings, which we do not want to show to our users.
So set it to silent mode by default. In case for any shelljs command you want to show the warnings, just set silent to false before executing it.
@rosen-vladimirov
rosen-vladimirovforce-pushed the vladimirov/update-shelljs-definitions branch from ebc905f to 9507f18CompareNovember 20, 2015 07:17
@ns-bot

Copy link
Copy Markdown

Test PASSed.

rosen-vladimirov added a commit that referenced this pull request Nov 20, 2015
@rosen-vladimirov
rosen-vladimirov merged commit 441f927 into releaseNov 20, 2015
@rosen-vladimirov
rosen-vladimirov deleted the vladimirov/update-shelljs-definitions branch November 20, 2015 07:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rosen-vladimirov@ns-bot@teobugslayer