Uh oh!
There was an error while loading. Please reload this page.
Fix cocoapods check and add unit tests for doctor service - #1248
Merged
Conversation
ns-bot
commented
Nov 25, 2015
Test FAILed. |
rosen-vladimirovforce-pushed
the
vladimirov/fix-cocoapods-check
branch
2 times, most recently
from
November 25, 2015 16:05
44b19bd to
1722709Comparens-bot
commented
Nov 25, 2015
Test FAILed. |
1 similar comment
ns-bot
commented
Nov 25, 2015
Test FAILed. |
rosen-vladimirovforce-pushed
the
vladimirov/fix-cocoapods-check
branch
from
November 25, 2015 18:14
1722709 to
a428275Comparens-bot
commented
Nov 25, 2015
Test FAILed. |
rosen-vladimirovforce-pushed
the
vladimirov/fix-cocoapods-check
branch
from
November 25, 2015 18:24
a428275 to
d78a885Comparens-bot
commented
Nov 25, 2015
Test PASSed. |
rosen-vladimirovforce-pushed
the
vladimirov/fix-cocoapods-check
branch
from
November 26, 2015 07:13
d78a885 to
a16713cComparens-bot
commented
Nov 26, 2015
Test PASSed. |
teobugslayer
commented
Nov 26, 2015
Contributor
👍 |
When cocoapods are not installed on Mac machine, doctor is failing. Fix this by skipping match check in case pods are not installed. Add basic unit tests for doctor service. Add unit test for the failing cocoapods check.
rosen-vladimirovforce-pushed
the
vladimirov/fix-cocoapods-check
branch
from
November 26, 2015 10:23
a16713c to
cea0f36Comparens-bot
commented
Nov 26, 2015
Test PASSed. |
rosen-vladimirov added a commit
that referenced
this pull request
Nov 26, 2015
…heck Fix cocoapods check and add unit tests for doctor service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cocoapods are not installed on Mac machine, doctor is failing.
Fix this by skipping match check in case pods are not installed.
Add basic unit tests for doctor service.
Add unit test for the failing cocoapods check.