Uh oh!
There was an error while loading. Please reload this page.
Do not show help when hook fails - #1279
Merged
Merged
Conversation
ns-bot
commented
Nov 30, 2015
Test PASSed. |
teobugslayer
commented
Dec 1, 2015
Contributor
👍 |
When any of the hooks fail, we show help of the command. Hooks failure is not bad user input, so we should not show help.
rosen-vladimirovforce-pushed
the
vladimirov/hooks-skip-help
branch
from
December 1, 2015 07:15
b07cc59 to
eb91029Comparens-bot
commented
Dec 1, 2015
Test PASSed. |
rosen-vladimirov added a commit
that referenced
this pull request
Dec 1, 2015
Do not show help when hook fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When any of the hooks fail, we show help of the command.
Hooks failure is not bad user input, so we should not show help.
Fixes#1268