Skip to content

Android releated commands - platform add, prepare, build and platform list - #6

Merged
Fatme merged 19 commits into
masterfrom
fatme/platform-command
Jul 17, 2014
Merged

Android releated commands - platform add, prepare, build and platform list#6
Fatme merged 19 commits into
masterfrom
fatme/platform-command

Conversation

@Fatme

Copy link
Copy Markdown
Contributor

No description provided.

@Fatme

Copy link
Copy Markdown
ContributorAuthor

@tailsu@ligaz

@FatmeFatme changed the title "Platform add android" command"Platform add android" and platform list commandsJul 15, 2014
@FatmeFatme changed the title "Platform add android" and platform list commands"Platform add android" and "platform list" commandsJul 15, 2014
Comment threadlib/nativescript-cli.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't ship with DEBUG: true. I suggest you use an environment variable for the purpose, e.g. set NATIVESCRIPT_DEBUG=true before running tns commands.

@FatmeFatme changed the title "Platform add android" and "platform list" commandsAndroid releated commands - platform add, prepare, build and platform listJul 16, 2014
@Fatme

Copy link
Copy Markdown
ContributorAuthor

@tailsu@ligaz

@ligaz

Copy link
Copy Markdown

Do we need the -command suffix for the commands file names? They are already in the commands folder 😄

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern seems repeated with the one in NodePackageManager. Consider adding a helper similar to the one in the Q library. https://github.com/kriskowal/q/wiki/API-Reference#qnfbindnodefunc-args

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea, but I think it would be better to do it in another PR. Agree?

@Fatme

Copy link
Copy Markdown
ContributorAuthor

@ligaz

@tailsu

Copy link
Copy Markdown
Contributor

👍

Fatme added a commit that referenced this pull request Jul 17, 2014
Android releated commands - platform add, prepare, build and platform list
@Fatme
Fatme merged commit e39b49c into masterJul 17, 2014
@Fatme
Fatme deleted the fatme/platform-command branch July 17, 2014 11:07
rigor789 pushed a commit that referenced this pull request Feb 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Fatme@ligaz@tailsu