Skip to content

Support static libraries in plugins for iOS. - #885

Merged
e2l3n merged 2 commits into
masterfrom
tpopov/static-libs
Sep 10, 2015
Merged

Support static libraries in plugins for iOS.#885
e2l3n merged 2 commits into
masterfrom
tpopov/static-libs

Conversation

@e2l3n

@e2l3ne2l3n commented Sep 7, 2015

Copy link
Copy Markdown
Contributor

Implement ability to use static libraries in iOS projects.
Implement unit tests.
Addresses issue #686

@ns-bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@e2l3n
e2l3nforce-pushed the tpopov/static-libs branch 2 times, most recently from 26dac8d to 43e7ac0CompareSeptember 7, 2015 19:19
@e2l3ne2l3n added feature and removed feature labels Sep 8, 2015
Comment threadlib/services/ios-project-service.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use template strings.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider explaining the user how to fix the issue - i.e. - can they use another command?

Comment threadlib/definitions/xcode.d.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why does this empty space not trigger the linter? At any rate, please remove it.

@teobugslayer

Copy link
Copy Markdown
Contributor
>> lib/services/ios-project-service.ts[200, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[211, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[215, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[239, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[242, 53]: trailing whitespace
>> lib/services/ios-project-service.ts[249, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[254, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[257, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[367, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[377, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[420, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[438, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[444, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[445, 61]: trailing whitespace
>> lib/services/ios-project-service.ts[447, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[448, 43]: trailing whitespace
>> lib/services/ios-project-service.ts[483, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[493, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[521, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[525, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[529, 52]: trailing whitespace
>> lib/services/ios-project-service.ts[530, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[560, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[565, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[570, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[574, 1]: trailing whitespace
>> test/ios-project-service.ts[172, 1]: trailing whitespace
>> test/ios-project-service.ts[180, 1]: trailing whitespace
>> test/ios-project-service.ts[184, 1]: trailing whitespace
>> test/ios-project-service.ts[191, 1]: trailing whitespace
>> test/ios-project-service.ts[198, 1]: trailing whitespace
>> test/ios-project-service.ts[201, 1]: trailing whitespace
>> test/ios-project-service.ts[219, 29]: trailing whitespace
>> test/ios-project-service.ts[220, 1]: trailing whitespace
>> test/ios-project-service.ts[224, 1]: trailing whitespace
>> test/ios-project-service.ts[222, 8]: unused variable: 'fs'

@teobugslayerteobugslayer added this to the 1.4.0 milestone Sep 8, 2015
Comment threadlib/services/ios-project-service.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab issues?

@e2l3n
e2l3nforce-pushed the tpopov/static-libs branch 2 times, most recently from 8727b13 to 07356fdCompareSeptember 10, 2015 10:57
@e2l3n

Copy link
Copy Markdown
ContributorAuthor

Rebase current branch onto master.

@e2l3n
e2l3nforce-pushed the tpopov/static-libs branch 3 times, most recently from ec6a37e to e9c8d01CompareSeptember 10, 2015 11:50
@teobugslayer

Copy link
Copy Markdown
Contributor

👍

@dtopuzov

Copy link
Copy Markdown
Contributor

run ci

@dtopuzovdtopuzov reopened this Sep 10, 2015
@ns-bot

Copy link
Copy Markdown

@ns-bot

Copy link
Copy Markdown

e2l3n added a commit that referenced this pull request Sep 10, 2015
Support static libraries in plugins for iOS.
@e2l3n
e2l3n merged commit e50c9b4 into masterSep 10, 2015
@teobugslayer
teobugslayer deleted the tpopov/static-libs branch October 2, 2015 09:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@e2l3n@ns-bot@teobugslayer@dtopuzov@Fatme@ikoevska