Uh oh!
There was an error while loading. Please reload this page.
Update index.ios.ts to remove callback on cancel of DateTimePicker dialog. - #277
Update index.ios.ts to remove callback on cancel of DateTimePicker dialog.#277mrwrighty wants to merge 1 commit into
Conversation
Removed callback(null) for CancelAction in iOS. If left in results in datePickerClosed being called.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
mrwrighty
commented
May 24, 2022
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
NathanWalker
commented
May 28, 2022
Isn't a cancel a close though? Just wondering without anything to notify when canceled would leave out a way to respond to when the datepicker is no longer on screen, which you may want if doing other ui or data reactions when showing the datepicker. Idk? |
mrwrighty
commented
May 28, 2022
Cancel is a close but still calls onDateChanged even though callback(null) is used. By removing the callback(null) the datetimepicker just closes with no event. |
Removed callback(null) for cancelAction in iOS. If left in this results in datePickerClosed event being called.