Uh oh!
There was an error while loading. Please reload this page.
feat(android): implement BorderDrawable outline - #158
Conversation
Uh oh!
There was an error while loading. Please reload this page.
manoldonev
commented
Feb 15, 2019
test |
etabakov
commented
Mar 1, 2019
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
rdlauer
commented
Mar 15, 2019
Hi - could we get a status update on this PR? Getting pinged about it regularly. |
SvetoslavTsenov
commented
Mar 18, 2019
test |
manoldonev
commented
Mar 18, 2019
@edusperoni our QAs identified a failing ui test triggered by this change: |
manoldonev
commented
Mar 18, 2019
Can be reproduced with this xml markup (correct behavior is that there shouldn't be any grayish left/right border): <Pageclass="page"navigatingTo="onNavigatingTo"xmlns="http://schemas.nativescript.org/tns.xsd">
<ActionBarclass="action-bar">
<Labelclass="action-bar-title"text="Home"></Label>
</ActionBar>
<GridLayoutrows="*,*,*"columns="*,*,*">
<Buttonrow="1"col="1"textWrap="true"text="border-width: 5 0; border-color: black;"style="border-width: 5 0; border-color: black;" />
</GridLayout>
</Page> |
Hey @edusperoni, |



PR Checklist
What is the current behavior?
BorderDrawable does not have an outline
What is the new behavior?
BorderDrawable has an outline
Provides initial support for NativeScript/NativeScript#550
Are there any tests to run?