Uh oh!
There was an error while loading. Please reload this page.
fix(review): only the finding goes to the forge - #32
Merged
Conversation
A thread's replies were concatenated onto the finding under an author label, so an answer arrived on the pull request while the question that prompted it stayed local — the question being an aside, the answer not. Where the agent had also amended the finding, the answer arrived twice, once folded in and once verbatim. Only the finding travels now. Everything said after it was said to work out what the finding should say, so amending it is how an answer reaches the pull request, and the discussion stays where it happened. The dialog still counts local replies, and now says they are not sent. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
The first pass fixed line comments and left the summary doing the same thing, without even the kind filter: every comment on a general thread was mapped into the posted body, so an aside on the summary would have gone to the forge. Both channels take the rule through one `findingOf` now. `find` rather than filter-and-destructure, returning `string | undefined` so the no-finding case is in the type instead of a footnote about which caller guards it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs
fiddur
marked this pull request as ready for review
August 25, 2026 09:26
fiddur added a commit
that referenced
this pull request
Aug 25, 2026
A running instance replaces itself only when the binary version differs from the one it registered (`isStale` in `packages/cli/src/index.ts`). So a merge without a bump leaves every instance that is already open serving the old build, silently. #31 and #32 both went in that way — six instances here are still on 0.9.6. Three things: - **`AGENTS.md`** with the rule. It is the first agent-facing doc in the repo. - **`--no-git` on `scripts/release.ts`**, without which the rule cannot be followed: the script commits and tags, and since develop takes squash merges the commit is rewritten on the way in and the tag is left pointing at a commit that never lands. Default behaviour is unchanged. - **v0.9.7**, the rule applied to its own PR. parser 43, git 44, github 21, ui 371, cli 157; the built binary reports 0.9.7. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread's replies were concatenated onto the finding under an author label, so an answer landed on the pull request while the question that prompted it stayed local — the question being an aside, the answer not. Where the agent had also amended the finding, the answer arrived twice: once folded into the amendment, once verbatim below it.
NCBackend3#14380 is what that looks like.
Only the finding travels now. Amending it is how an answer reaches the pull request; the conversation that produced it stays local.
Worth knowing: a reply the agent never folded into the finding now goes nowhere. That is the intent, but it does put the whole weight on the agent amending — the dialog says
+N replies · not sentso at least it is visible before submitting.threadToPayloadhad three tests asserting the concatenation; those now assert the opposite, plus one for the amend-and-reply case above. Mutation-checked: restoring the concatenation turns all four red. parser 43, git 44, github 21, ui 369, cli 157.🤖 Generated with Claude Code
https://claude.ai/code/session_018PkYQzbsnMihHesafWvXKs